Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: Source/modules/device_orientation/WebDeviceMotionDispatcher.h

Issue 14460010: Implement the Blink part of the Device Motion API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fixed Adam's comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/device_orientation/WebDeviceMotionDispatcher.h
diff --git a/Source/modules/device_orientation/WebDeviceMotionDispatcher.h b/Source/modules/device_orientation/WebDeviceMotionDispatcher.h
new file mode 100644
index 0000000000000000000000000000000000000000..d6b015eb52a0985b34f070e82589f2f218292cb1
--- /dev/null
+++ b/Source/modules/device_orientation/WebDeviceMotionDispatcher.h
@@ -0,0 +1,79 @@
+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WebDeviceMotionDispatcher_h
+#define WebDeviceMotionDispatcher_h
+
+#include "DeviceMotionData.h"
+#include <public/WebDeviceMotionListener.h>
+#include <wtf/HashCountedSet.h>
+#include <wtf/RefCounted.h>
+
+namespace WebCore {
+class DeviceMotionController;
+class DeviceMotionData;
+}
+
+namespace WebKit {
abarth-chromium 2013/05/07 16:43:47 This object should be in the WebCore namespace. (
timvolodine 2013/05/07 19:02:30 Done.
+
+class WebDeviceMotionData;
+
+// This class listens to device motion data and dispatches it to all
+// interested controllers.
+class WebDeviceMotionDispatcher : public WebDeviceMotionListener {
abarth-chromium 2013/05/07 16:43:47 WebDeviceMotionDispatcher -> DeviceMotionDispatche
timvolodine 2013/05/07 19:02:30 Done.
+public:
+ static WebDeviceMotionDispatcher& shared();
+
+ void addController(WebCore::DeviceMotionController*);
+ void removeController(WebCore::DeviceMotionController*);
+
+ // Note that the returned object is owned by this class.
+ // FIXME: make the return value const, see crbug.com/233174.
+ WebCore::DeviceMotionData* latestDeviceMotionData();
+
+ // This method is called every time new motion data is available.
+ void didChangeDeviceMotion(WebDeviceMotionData&) OVERRIDE;
+
+private:
+ WebDeviceMotionDispatcher();
+ ~WebDeviceMotionDispatcher();
+
+ void startListening();
+ void stopListening();
+
+ PassRefPtr<WebCore::DeviceMotionData> convertToDeviceMotionData(WebDeviceMotionData&);
abarth-chromium 2013/05/07 16:43:47 Thought you were going to make this an operator on
timvolodine 2013/05/07 19:02:30 Done.
+
+ RefPtr<WebCore::DeviceMotionData> m_lastDeviceMotionData;
+ HashCountedSet<RefPtr<WebCore::DeviceMotionController> > m_controllers;
abarth-chromium 2013/05/07 16:43:47 There's no need to use a RefPtr here. The DeviceM
timvolodine 2013/05/07 19:02:30 ack, done.
+};
+
+} // namespace WebCore
+
+#endif // WebDeviceMotionDispatcher_h

Powered by Google App Engine
This is Rietveld 408576698