Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: Source/modules/device_orientation/WebDeviceMotionDispatcher.h

Issue 14460010: Implement the Blink part of the Device Motion API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fixed Adam's comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are
6 * met:
7 *
8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above
11 * copyright notice, this list of conditions and the following disclaimer
12 * in the documentation and/or other materials provided with the
13 * distribution.
14 * * Neither the name of Google Inc. nor the names of its
15 * contributors may be used to endorse or promote products derived from
16 * this software without specific prior written permission.
17 *
18 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
19 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
20 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */
30
31 #ifndef WebDeviceMotionDispatcher_h
32 #define WebDeviceMotionDispatcher_h
33
34 #include "DeviceMotionData.h"
35 #include <public/WebDeviceMotionListener.h>
36 #include <wtf/HashCountedSet.h>
37 #include <wtf/RefCounted.h>
38
39 namespace WebCore {
40 class DeviceMotionController;
41 class DeviceMotionData;
42 }
43
44 namespace WebKit {
abarth-chromium 2013/05/07 16:43:47 This object should be in the WebCore namespace. (
timvolodine 2013/05/07 19:02:30 Done.
45
46 class WebDeviceMotionData;
47
48 // This class listens to device motion data and dispatches it to all
49 // interested controllers.
50 class WebDeviceMotionDispatcher : public WebDeviceMotionListener {
abarth-chromium 2013/05/07 16:43:47 WebDeviceMotionDispatcher -> DeviceMotionDispatche
timvolodine 2013/05/07 19:02:30 Done.
51 public:
52 static WebDeviceMotionDispatcher& shared();
53
54 void addController(WebCore::DeviceMotionController*);
55 void removeController(WebCore::DeviceMotionController*);
56
57 // Note that the returned object is owned by this class.
58 // FIXME: make the return value const, see crbug.com/233174.
59 WebCore::DeviceMotionData* latestDeviceMotionData();
60
61 // This method is called every time new motion data is available.
62 void didChangeDeviceMotion(WebDeviceMotionData&) OVERRIDE;
63
64 private:
65 WebDeviceMotionDispatcher();
66 ~WebDeviceMotionDispatcher();
67
68 void startListening();
69 void stopListening();
70
71 PassRefPtr<WebCore::DeviceMotionData> convertToDeviceMotionData(WebDeviceMot ionData&);
abarth-chromium 2013/05/07 16:43:47 Thought you were going to make this an operator on
timvolodine 2013/05/07 19:02:30 Done.
72
73 RefPtr<WebCore::DeviceMotionData> m_lastDeviceMotionData;
74 HashCountedSet<RefPtr<WebCore::DeviceMotionController> > m_controllers;
abarth-chromium 2013/05/07 16:43:47 There's no need to use a RefPtr here. The DeviceM
timvolodine 2013/05/07 19:02:30 ack, done.
75 };
76
77 } // namespace WebCore
78
79 #endif // WebDeviceMotionDispatcher_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698