Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1445913002: Oilpan: track ScriptStateForTesting's ExecutionContext reference better. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: track ScriptStateForTesting's ExecutionContext reference better. R=haraken BUG=553613 Committed: https://crrev.com/762b858e8f7e89fdf7e4928480b03c36355cf5c3 Cr-Commit-Position: refs/heads/master@{#359750}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h View 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sof
5 years, 1 month ago (2015-11-14 07:12:18 UTC) #2
haraken
LGTM https://codereview.chromium.org/1445913002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h File third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h (right): https://codereview.chromium.org/1445913002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h#newcode24 third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h:24: RawPtrWillBePersistent<ExecutionContext> m_executionContext; Nit: This could be RefPtrWillBePersistent.
5 years, 1 month ago (2015-11-14 07:13:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445913002/1
5 years, 1 month ago (2015-11-14 08:11:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-15 02:39:02 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 02:40:38 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/762b858e8f7e89fdf7e4928480b03c36355cf5c3
Cr-Commit-Position: refs/heads/master@{#359750}

Powered by Google App Engine
This is Rietveld 408576698