third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h - Issue 1445913002: Oilpan: track ScriptStateForTesting's ExecutionContext reference better.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h

Issue 1445913002: Oilpan: track ScriptStateForTesting's ExecutionContext reference better. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h b/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h

index bd80192f33a6aa19b9a305daf92d04a1ede17af9..6b7c973c8b20cb4b37bd7ab55b18b8c699ea7953 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h

@@ -21,7 +21,7 @@ public:

void setExecutionContext(ExecutionContext*) override;

private:

ScriptStateForTesting(v8::Local<v8::Context>, PassRefPtr<DOMWrapperWorld>);

- ExecutionContext* m_executionContext;

+ RawPtrWillBePersistent<ExecutionContext> m_executionContext;

haraken 2015/11/14 07:13:35 Nit: This could be RefPtrWillBePersistent.

};

class V8TestingScope {

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp » ('j') | no next file with comments »