Issue 14458009: Mark hidden menu items on about:net-internals as disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14458009: Mark hidden menu items on about:net-internals as disabled. (Closed)

Created:
7 years, 8 months ago by eroman

Modified:
7 years, 8 months ago

Reviewers:
mmenke

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mark hidden menu items on about:net-internals as disabled. If you don't they can be selected via the keyboard when cycling through the tab switcher menu. Which is just weird. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196769

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/browser/resources/net_internals/tab_switcher_view.js	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mmenke

On 2013/04/26 03:35:49, eroman wrote: > (please hit commit box if you approve) LGTM

7 years, 8 months ago (2013-04-26 14:40:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/14458009/1

7 years, 8 months ago (2013-04-26 14:40:17 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=107453

7 years, 8 months ago (2013-04-26 17:23:17 UTC) #4

eroman

7 years, 8 months ago (2013-04-26 17:56:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r196769 (presubmit successful).

Expand Messages | Collapse Messages