Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: chrome/browser/resources/net_internals/tab_switcher_view.js

Issue 14458009: Mark hidden menu items on about:net-internals as disabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/net_internals/tab_switcher_view.js
diff --git a/chrome/browser/resources/net_internals/tab_switcher_view.js b/chrome/browser/resources/net_internals/tab_switcher_view.js
index 16347ad162f490b42de9eedfa67a43f45b185e25..9abdc87b5aa228ba914f7db643e9577ecef18ec5 100644
--- a/chrome/browser/resources/net_internals/tab_switcher_view.js
+++ b/chrome/browser/resources/net_internals/tab_switcher_view.js
@@ -93,7 +93,12 @@ var TabSwitcherView = (function() {
showMenuItem: function(tabId, isVisible) {
var wasActive = this.activeTabId_ == tabId;
- setNodeDisplay(this.getMenuItemNode_(tabId), isVisible);
+
+ // Hide the menuitem from the list. Note it needs to be 'disabled' to
+ // prevent it being selectable from keyboard.
+ var menuitem = this.getMenuItemNode_(tabId);
+ setNodeDisplay(menuitem, isVisible);
+ menuitem.disabled = !isVisible;
if (wasActive && !isVisible) {
// If the active tab is being hidden in the dropdown menu, then
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698