Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: gpu/command_buffer/client/gpu_memory_buffer_factory.h

Issue 14456004: GPU client side changes for GpuMemoryBuffers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@glapi
Patch Set: More code reviews Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gpu_memory_buffer_factory.h
diff --git a/gpu/command_buffer/client/gpu_memory_buffer_factory.h b/gpu/command_buffer/client/gpu_memory_buffer_factory.h
index dd10a7d77c66a552acb09f4a8517240abde821c5..bbcc5a117aeb82252fc47aebc41eead16c4ff87d 100644
--- a/gpu/command_buffer/client/gpu_memory_buffer_factory.h
+++ b/gpu/command_buffer/client/gpu_memory_buffer_factory.h
@@ -9,6 +9,7 @@
#include "gpu/command_buffer/client/gpu_memory_buffer.h"
namespace gpu {
+namespace gles2 {
// Getter and setter for a GpuMemoryBuffer factory for the current process.
// Currently it is only used for Android Webview where both browser and
@@ -22,6 +23,16 @@ GLES2_IMPL_EXPORT const GpuMemoryBuffer::Creator&
GLES2_IMPL_EXPORT void SetProcessDefaultGpuMemoryBufferFactory(
const GpuMemoryBuffer::Creator& factory);
+class GpuMemoryBufferFactory {
reveman 2013/05/03 22:45:00 The GpuMemoryBuffer::Creator stuff above is platfo
kaanb 2013/05/06 18:20:53 Actually since I refactored the class into WGC3DIP
+ public:
+ virtual ~GpuMemoryBufferFactory() {}
+ // Craete a GpuMemoryBuffer and makes it available to the
+ // service side by inserting it to the ImageManager.
+ virtual scoped_ptr<GpuMemoryBuffer> CreateGpuMemoryBuffer(
+ int width, int height, int image_id) = 0;
+};
+
+} // namespace gles2
} // namespace gpu
#endif // GPU_COMMAND_BUFFER_CLIENT_GPU_MEMORY_BUFFER_FACTORY_H_

Powered by Google App Engine
This is Rietveld 408576698