GPU client side changes for GpuMemoryBuffers

gpu/command_buffer/client/gpu_memory_buffer_tracker.cc

Index: gpu/command_buffer/client/gpu_memory_buffer_tracker.cc
diff --git a/gpu/command_buffer/client/gpu_memory_buffer_tracker.cc b/gpu/command_buffer/client/gpu_memory_buffer_tracker.cc
new file mode 100644
index 0000000000000000000000000000000000000000..21d04739837c57219ef302cf678409d446a66dab
--- /dev/null
+++ b/gpu/command_buffer/client/gpu_memory_buffer_tracker.cc
@@ -0,0 +1,51 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "../client/gpu_memory_buffer_tracker.h"
+
+#include "../client/gpu_memory_buffer_factory.h"
+
+namespace gpu {
+namespace gles2 {
+
+GpuMemoryBufferTracker::GpuMemoryBufferTracker(GpuMemoryBufferFactory* factory)
+    : buffers_(),
+      factory_(factory) {
+}
+
+GpuMemoryBufferTracker::~GpuMemoryBufferTracker() {
+  while (!buffers_.empty()) {
+    RemoveBuffer(buffers_.begin()->first);
+  }
+}
+
+GpuMemoryBuffer* GpuMemoryBufferTracker::CreateBuffer(
+    GLuint image_id, GLsizei width, GLsizei height) {
+  GPU_DCHECK_NE(0u, image_id);
+  GpuMemoryBuffer* buffer =
+      factory_->CreateGpuMemoryBuffer(width, height, image_id).release();

[reveman, 2013/05/03 22:45:00]

release()? either use the scoped_ptr or have GpuMemoryBufferFactory return a raw
pointer.

[kaanb, 2013/05/06 18:20:53]

Unfortunately you cannot insert scoped_ptr()s into STL containers and we thought
using scoped_ptr would make sense in the API as it signals ownership of the
buffer is being transferred.

[reveman, 2013/05/07 02:25:03]

Ah, you'd want to use ScopedPtrHashMap here if that was not specific to cc/.
Please move the release() call to when you insert the buffer in the hash_map.
That will make it easier to understand why you need this.

[kaanb, 2013/05/08 00:32:36]

Done.

+
+  std::pair<BufferMap::iterator, bool> result =
+      buffers_.insert(std::make_pair(image_id, buffer));
+  GPU_DCHECK(result.second);
+
+  return buffer;
+}
+
+GpuMemoryBuffer* GpuMemoryBufferTracker::GetBuffer(GLuint image_id) {
+  BufferMap::iterator it = buffers_.find(image_id);
+  return (it != buffers_.end()) ? it->second : NULL;
+}
+
+void GpuMemoryBufferTracker::RemoveBuffer(GLuint image_id) {
+  BufferMap::iterator buffer_it = buffers_.find(image_id);
+  if (buffer_it != buffers_.end()) {
+    GpuMemoryBuffer* buffer = buffer_it->second;
+    buffers_.erase(buffer_it);
+    delete buffer;
+  }
+}
+
+}  // namespace gles2
+}  // namespace gpu