Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1445553003: Revert of [Android] Enhanced bookmark default mobile folder experiment. (Closed)

Created:
5 years, 1 month ago by Kibeom Kim (inactive)
Modified:
5 years, 1 month ago
Reviewers:
Ian Wen
CC:
chromium-reviews, Eli Wald
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Enhanced bookmark default mobile folder experiment. (patchset #1 id:1 of https://codereview.chromium.org/1425293009/ ) Reason for revert: This CL had a bug that when experiment is turned on, it always forwards all bookmarks to mobile folder. Original issue's description: > [Android] Enhanced bookmark default mobile folder experiment. > > BUG=552508 > > Committed: https://crrev.com/964c0baff2687c52a43935fafca4ee07790b047e > Cr-Commit-Position: refs/heads/master@{#358441} TBR=ianwen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=552508 Committed: https://crrev.com/1a111a94db99f39773af78c4c3ad2b60ea21eeec Cr-Commit-Position: refs/heads/master@{#359599}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java View 1 3 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Kibeom Kim (inactive)
Created Revert of [Android] Enhanced bookmark default mobile folder experiment.
5 years, 1 month ago (2015-11-13 19:03:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445553003/1
5 years, 1 month ago (2015-11-13 19:06:56 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java: While running git apply --index -3 -p1; error: patch ...
5 years, 1 month ago (2015-11-13 19:09:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445553003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445553003/40001
5 years, 1 month ago (2015-11-13 19:26:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 1 month ago (2015-11-13 19:28:48 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 19:29:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a111a94db99f39773af78c4c3ad2b60ea21eeec
Cr-Commit-Position: refs/heads/master@{#359599}

Powered by Google App Engine
This is Rietveld 408576698