Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4815)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java

Issue 1445553003: Revert of [Android] Enhanced bookmark default mobile folder experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
index 601b7d415cf06b76e44492607443528076fade62..99c8f0c60d6126e4d221763d55975ce78010c288 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
@@ -31,7 +31,6 @@ import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.snackbar.SnackbarManager;
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarManageable;
import org.chromium.components.bookmarks.BookmarkId;
-import org.chromium.components.variations.VariationsAssociatedData;
import org.chromium.ui.base.DeviceFormFactor;
import java.io.UnsupportedEncodingException;
@@ -51,8 +50,6 @@ import java.util.Stack;
public class EnhancedBookmarkManager implements EnhancedBookmarkDelegate {
private static final String PREF_LAST_USED_URL = "enhanced_bookmark_last_used_url";
private static final int FAVICON_MAX_CACHE_SIZE_BYTES = 10 * 1024 * 1024; // 10MB
- private static final String FIELD_TRIAL_NAME = "EnhancedBookmarks";
- private static final String DEFAULT_FOLDER = "default_folder";
private Activity mActivity;
private ViewGroup mMainView;
@@ -547,14 +544,7 @@ public class EnhancedBookmarkManager implements EnhancedBookmarkDelegate {
state.mUrl = url;
if (url.equals(UrlConstants.BOOKMARKS_URL)) {
- if (VariationsAssociatedData
- .getVariationParamValue(FIELD_TRIAL_NAME, DEFAULT_FOLDER)
- .equals("mobile")) {
- state.mFolder = bookmarkModel.getMobileFolderId();
- state.mState = STATE_FOLDER;
- } else {
- state.mState = STATE_ALL_BOOKMARKS;
- }
+ state.mState = STATE_ALL_BOOKMARKS;
} else if (url.startsWith(UrlConstants.BOOKMARKS_FOLDER_URL)) {
String suffix = decodeSuffix(url, UrlConstants.BOOKMARKS_FOLDER_URL);
if (!suffix.isEmpty()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698