Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1445443004: Add performance tests for adding options to a select element. (Closed)

Created:
5 years, 1 month ago by tkent
Modified:
5 years, 1 month ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add performance tests for adding options to a select element. Also, add TRACE to HTMLSelectElement::recalcListItems and selctOption. They can be bottlenecks. BUG=511563 Committed: https://crrev.com/7a4c4a4ae12d8a0d3a87b9d82fc7baf602fd5053 Cr-Commit-Position: refs/heads/master@{#359520}

Patch Set 1 #

Total comments: 2

Patch Set 2 : consistent quotes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
A third_party/WebKit/PerformanceTests/DOM/select-multiple-add.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/DOM/select-single-add.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tkent
Keishi, would you review this please?
5 years, 1 month ago (2015-11-13 05:26:13 UTC) #3
keishi
LGTM https://codereview.chromium.org/1445443004/diff/1/third_party/WebKit/PerformanceTests/DOM/select-single-add.html File third_party/WebKit/PerformanceTests/DOM/select-single-add.html (right): https://codereview.chromium.org/1445443004/diff/1/third_party/WebKit/PerformanceTests/DOM/select-single-add.html#newcode15 third_party/WebKit/PerformanceTests/DOM/select-single-add.html:15: description: "Measures performance of adding option elements to ...
5 years, 1 month ago (2015-11-13 07:16:40 UTC) #4
tkent
https://codereview.chromium.org/1445443004/diff/1/third_party/WebKit/PerformanceTests/DOM/select-single-add.html File third_party/WebKit/PerformanceTests/DOM/select-single-add.html (right): https://codereview.chromium.org/1445443004/diff/1/third_party/WebKit/PerformanceTests/DOM/select-single-add.html#newcode15 third_party/WebKit/PerformanceTests/DOM/select-single-add.html:15: description: "Measures performance of adding option elements to a ...
5 years, 1 month ago (2015-11-13 08:07:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445443004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445443004/20001
5 years, 1 month ago (2015-11-13 08:08:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-13 09:22:07 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 09:23:07 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a4c4a4ae12d8a0d3a87b9d82fc7baf602fd5053
Cr-Commit-Position: refs/heads/master@{#359520}

Powered by Google App Engine
This is Rietveld 408576698