Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 1445443004: Add performance tests for adding options to a select element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: consistent quotes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/PerformanceTests/DOM/select-single-add.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
index 358e5f4963e665991b9259b835a896384d1a39dc..753ca86478ff45cabf7a80fa72d2dd707f6d4d2a 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
@@ -66,6 +66,7 @@
#include "core/page/SpatialNavigation.h"
#include "platform/PlatformMouseEvent.h"
#include "platform/PopupMenu.h"
+#include "platform/TraceEvent.h"
#include "platform/text/PlatformLocale.h"
using namespace WTF::Unicode;
@@ -797,6 +798,7 @@ void HTMLSelectElement::setRecalcListItems()
void HTMLSelectElement::recalcListItems(bool updateSelectedStates) const
{
+ TRACE_EVENT0("blink", "HTMLSelectElement::recalcListItems");
m_listItems.clear();
m_shouldRecalcListItems = false;
@@ -962,6 +964,7 @@ void HTMLSelectElement::optionRemoved(const HTMLOptionElement& option)
// operations.
void HTMLSelectElement::selectOption(int optionIndex, SelectOptionFlags flags)
{
+ TRACE_EVENT0("blink", "HTMLSelectElement::selectOption");
bool shouldDeselect = !m_multiple || (flags & DeselectOtherOptions);
const WillBeHeapVector<RawPtrWillBeMember<HTMLElement>>& items = listItems();
« no previous file with comments | « third_party/WebKit/PerformanceTests/DOM/select-single-add.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698