chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm - Issue 1445383003: Introduce PasswordsModelDelegate as an abstraction between ManagePasswordsBubbleModel and ManagePas…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

Issue 1445383003: Introduce PasswordsModelDelegate as an abstraction between ManagePasswordsBubbleModel and ManagePas… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Mac Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_test_base.cc ('K') | « chrome/browser/password_manager/password_manager_test_base.cc ('k') | chrome/browser/ui/passwords/manage_passwords_bubble_model.h » ('j') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

index 2cc4dbaa97ee9aa5a54ce6dc35750086b0f1e985..1702b19372a453ce62ad71962cf0f09453d970d8 100644

--- a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

@@ -156,14 +156,10 @@ TEST_F(ManagePasswordsBubbleAccountChooserViewControllerTest,

federated_forms.Pass(),

GURL("http://example.com"),

base::Callback<void(const password_manager::CredentialInfo&)>()));

- EXPECT_EQ(password_manager::ui::CREDENTIAL_REQUEST_STATE,

vabr (Chromium) 2015/11/18 08:59:45 Why is it OK to remove these checks?

vasilii 2015/11/18 12:27:45 Because it tests the mock UI controller. This clas

vabr (Chromium) 2015/11/18 12:36:40 Acknowledged.

- ui_controller()->state());

[controller().credentialsView

selectRowIndexes:[NSIndexSet indexSetWithIndex:1]

byExtendingSelection:NO];

EXPECT_TRUE(delegate().dismissed);

- EXPECT_EQ(password_manager::ui::CREDENTIAL_REQUEST_STATE,

- ui_controller()->state());

EXPECT_TRUE(ui_controller()->choose_credential());

EXPECT_EQ(base::ASCIIToUTF16("taco"),

ui_controller()->chosen_credential().username_value);