Introduce PasswordsModelDelegate as an abstraction between ManagePasswordsBubbleModel and ManagePas…

chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h"
 
 #include "base/mac/foundation_util.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 138 matching lines @@
        SelectingCredentialInformsModelAndClosesDialog) {
   ScopedVector<autofill::PasswordForm> local_forms;
   local_forms.push_back(Credential("pizza"));
   ScopedVector<autofill::PasswordForm> federated_forms;
   federated_forms.push_back(Credential("taco"));
   EXPECT_TRUE(ui_controller()->OnChooseCredentials(
       local_forms.Pass(),
       federated_forms.Pass(),
       GURL("http://example.com"),
       base::Callback<void(const password_manager::CredentialInfo&)>()));
-  EXPECT_EQ(password_manager::ui::CREDENTIAL_REQUEST_STATE,

[vabr (Chromium), 2015/11/18 08:59:45]

Why is it OK to remove these checks?

[vasilii, 2015/11/18 12:27:45]

Because it tests the mock UI controller. This class is 3 layers far from the
code which should really be tested here.

[vabr (Chromium), 2015/11/18 12:36:40]

Acknowledged.

-            ui_controller()->state());
   [controller().credentialsView
           selectRowIndexes:[NSIndexSet indexSetWithIndex:1]
       byExtendingSelection:NO];
   EXPECT_TRUE(delegate().dismissed);
-  EXPECT_EQ(password_manager::ui::CREDENTIAL_REQUEST_STATE,
-            ui_controller()->state());
   EXPECT_TRUE(ui_controller()->choose_credential());
   EXPECT_EQ(base::ASCIIToUTF16("taco"),
             ui_controller()->chosen_credential().username_value);
 }
 
 TEST_F(ManagePasswordsBubbleAccountChooserViewControllerTest,
        SelectingNopeDismissesDialog) {
   ScopedVector<autofill::PasswordForm> local_forms;
   local_forms.push_back(Credential("pizza"));
   EXPECT_TRUE(ui_controller()->OnChooseCredentials(
@@ skipping 18 matching lines @@
        SelectingLearnMoreShowsHelpCenterArticle) {
   BubbleCombobox* moreButton = controller().moreButton;
   EXPECT_TRUE(moreButton);
   [[moreButton menu] performActionForItemAtIndex:
                          AccountChooserMoreComboboxModel::INDEX_LEARN_MORE];
   EXPECT_TRUE(delegate().dismissed);
   // TODO(dconnelly): Test this when the article is written.
 }
 
 }  // namespace