Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 144533003: Don't crash in Array.join() if the resulting string exceeds the max string length. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer
Modified:
6 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Don't crash in Array.join() if the resulting string exceeds the max string length. LOG=y BUG=336820 R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18986

Patch Set 1 #

Patch Set 2 : Add regression test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 2 chunks +7 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-336820.js View 1 1 chunk +9 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 10 months ago (2014-01-31 12:08:49 UTC) #1
Sven Panne
lgtm
6 years, 10 months ago (2014-01-31 12:18:36 UTC) #2
Benedikt Meurer
6 years, 10 months ago (2014-01-31 12:21:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r18986 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698