Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: test/mjsunit/regress/regress-336820.js

Issue 144533003: Don't crash in Array.join() if the resulting string exceeds the max string length. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add regression test. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-336820.js
diff --git a/test/mjsunit/regress/regress-334708.js b/test/mjsunit/regress/regress-336820.js
similarity index 88%
copy from test/mjsunit/regress/regress-334708.js
copy to test/mjsunit/regress/regress-336820.js
index f0291bbdab61128baad9df89457d045b66644f1b..9b466296043b858df75b7f1fe9f959b66abea969 100644
--- a/test/mjsunit/regress/regress-334708.js
+++ b/test/mjsunit/regress/regress-336820.js
@@ -25,18 +25,12 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Flags: --allow-natives-syntax
-
-function foo(x, y) {
- return Math.floor(x / y);
-}
-
-function bar(x, y) {
- return foo(x + 1, y + 1);
-}
-
-foo(16, "4");
-
-bar(64, 2);
-%OptimizeFunctionOnNextCall(bar);
-bar(64, 2);
+assertThrows((function() {
+ s = "Hello World!\n";
+ while (true) {
+ x = new Array();
+ x[0] = s;
+ x[1000] = s;
+ x[1000000] = s;
+ s = x.join("::");
+ }}), RangeError);
« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698