Issue 1444983002: Optimize 'isWithin'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1444983002: Optimize 'isWithin'. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Optimize 'isWithin'. Its "in stack" percent is down from 2.82% to 0.16% now. This makes total MDL project analysis about 3% faster. Also exchange the 'suffix' arguments to make them consistent with the parent/child order everywhere else. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9b7e011920ff2bd61066f2af99d4601d5220a63d

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -12 lines)			Patch
M	pkg/analysis_server/lib/src/context_manager.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/util/absolute_path.dart	View	3 chunks	+35 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/src/util/absolute_path_test.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 1 month ago (2015-11-16 16:45:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9b7e011920ff2bd61066f2af99d4601d5220a63d (presubmit successful).