Optimize 'isWithin'.

pkg/analysis_server/lib/src/context_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library context.directory.manager;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';
 import 'dart:core' hide Resource;
@@ skipping 1161 matching lines @@
     _checkForPackagespecUpdate(path, info, info.folder);
     _checkForAnalysisOptionsUpdate(path, info, event.type);
   }
 
   /**
    * Determine whether the given [path], when interpreted relative to the
    * context root [root], contains a folder whose name starts with '.'.
    */
   bool _isContainedInDotFolder(String root, String path) {
     String pathDir = absolutePathContext.dirname(path);
-    String suffixPath = absolutePathContext.suffix(pathDir, root);
+    String suffixPath = absolutePathContext.suffix(root, pathDir);
     if (suffixPath == null) {
       return false;
     }
     for (String pathComponent in absolutePathContext.split(suffixPath)) {
       if (pathComponent.startsWith('.') &&
           pathComponent != '.' &&
           pathComponent != '..') {
         return true;
       }
     }
@@ skipping 15 matching lines @@
       }
       return path == excludedPath;
     });
   }
 
   /**
    * Determine whether the given [path], when interpreted relative to the
    * context root [root], contains a 'packages' folder.
    */
   bool _isInPackagesDir(String root, String path) {
-    String suffixPath = absolutePathContext.suffix(path, root);
+    String suffixPath = absolutePathContext.suffix(root, path);
     if (suffixPath == null) {
       return false;
     }
     List<String> pathParts = absolutePathContext.split(suffixPath);
     return pathParts.contains(PACKAGES_NAME);
   }
 
   /**
    * Determine whether the given [path] is in the direct 'doc' folder of the
    * context root [root].
    */
   bool _isInTopLevelDocDir(String root, String path) {
-    String suffixPath = absolutePathContext.suffix(path, root);
+    String suffixPath = absolutePathContext.suffix(root, path);
     if (suffixPath == null) {
       return false;
     }
     return suffixPath == DOC_DIR_NAME ||
         suffixPath.startsWith(DOC_DIR_NAME + absolutePathContext.separator);
   }
 
   bool _isPackagespec(String path) =>
       absolutePathContext.basename(path) == PACKAGE_SPEC_NAME;
 
@@ skipping 227 matching lines @@
           var path = resourceProvider.pathContext.fromUri(uri);
           packageMap[name] = <Folder>[resourceProvider.getFolder(path)];
         }
       });
       return <UriResolver>[new SdkExtUriResolver(packageMap)];
     } else {
       return const <UriResolver>[];
     }
   }
 }