LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js - Issue 14447006: Global constructors should be configurable and not enumerable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js

Issue 14447006: Global constructors should be configurable and not enumerable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Clean rebase on master Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/js/global-constructors-attributes-expected.txt ('k') | LayoutTests/fast/js/script-tests/global-constructors.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js

diff --git a/LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js b/LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js

index 4f7ab5c9d795647ac026b824b6327905ac23bcf8..09c244d72b820d9e5d90d88d8b1dac1bed27ec11 100644

--- a/LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js

+++ b/LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js

@@ -43,7 +43,7 @@ descriptorShouldBe("global", "'undefined'", {writable: false, enumerable: false,

descriptorShouldBe("global", "'NaN'", {writable: false, enumerable: false, configurable: false, value:"NaN"});

descriptorShouldBe("global", "'Infinity'", {writable: false, enumerable: false, configurable: false, value:"Infinity"});

descriptorShouldBe("global", "'window'", {writable: false, enumerable: true, configurable: false, value:"global"});

-descriptorShouldBe("global", "'XMLHttpRequest'", {writable: true, enumerable: true, configurable: false, value:"XMLHttpRequest"});

+descriptorShouldBe("global", "'XMLHttpRequest'", {writable: true, enumerable: false, configurable: true, value:"XMLHttpRequest"});

descriptorShouldBe("global", "'length'", {writable: true, enumerable: true, configurable: false, value:"global.length"});

descriptorShouldBe("global", "0", {writable: true, enumerable: false, configurable: false, value:"global[0]"});

descriptorShouldBe("document.getElementsByTagName('div')", "'length'", {writable: false, enumerable: true, configurable: false, value:"1"});