LayoutTests/fast/js/script-tests/global-constructors.js - Issue 14447006: Global constructors should be configurable and not enumerable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/js/script-tests/global-constructors.js

Issue 14447006: Global constructors should be configurable and not enumerable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Clean rebase on master Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js ('k') | LayoutTests/fast/js/script-tests/global-constructors-attributes.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/js/script-tests/global-constructors.js

diff --git a/LayoutTests/fast/js/script-tests/global-constructors.js b/LayoutTests/fast/js/script-tests/global-constructors.js

index ae72ca20b369e4b1e35970a8e21082dc61aa3494..cb105df111feed55aea13fa632821f0ab0a5bf25 100644

--- a/LayoutTests/fast/js/script-tests/global-constructors.js

+++ b/LayoutTests/fast/js/script-tests/global-constructors.js

@@ -2,7 +2,9 @@ description("This test documents our set of global constructors we expose on the

var constructorNames = [];

-for (var name in window) {

+var windowProperties = Object.getOwnPropertyNames(window);

+for (var i = 0; i < windowProperties.length; i++) {

+ var name = windowProperties[i];

var value = window[name];

var re = new RegExp("Constructor]$");

var isConstructor = re.exec(value);