Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1444583002: [turbofan] Added the optional Float64RoundUp operator to turbofan. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
titzer, paul.l...
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Added the optional Float64RoundUp operator to turbofan. I implemented it on x64, ia32, arm, arm64, mips, mips64, and ppc. Committed: https://crrev.com/1389b9f53c90dca1ff123cf3a1e90c607dadfc90 Cr-Commit-Position: refs/heads/master@{#32004}

Patch Set 1 #

Patch Set 2 : Fixed a typo. #

Patch Set 3 : Disabled F64RoundUp on mips32 #

Patch Set 4 : Removed the implementation of VisitFloat32RoundUp on mips32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -46 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 2 chunks +13 lines, -11 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +21 lines, -35 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ahaas
5 years, 1 month ago (2015-11-13 11:44:31 UTC) #1
titzer
On 2015/11/13 11:44:31, ahaas wrote: lgtm
5 years, 1 month ago (2015-11-13 23:27:18 UTC) #3
paul.l...
The mips64 changes look good. There is a problem in mips32, not with your CL, ...
5 years, 1 month ago (2015-11-16 05:56:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444583002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444583002/60001
5 years, 1 month ago (2015-11-16 10:36:18 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-16 10:37:30 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 10:37:54 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1389b9f53c90dca1ff123cf3a1e90c607dadfc90
Cr-Commit-Position: refs/heads/master@{#32004}

Powered by Google App Engine
This is Rietveld 408576698