Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1444543002: Add visualbench option for nvpr stencil samples (Closed)

Created:
5 years, 1 month ago by Chris Dalton
Modified:
5 years, 1 month ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload_fix_triple_buffer
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add visualbench option for nvpr stencil samples Repurposes the --nvpr flag as an int that says how many stencil samples to use, or disables nvpr with a value of zero. BUG=skia: Committed: https://skia.googlesource.com/skia/+/60795d99fff8caedc2e82bebcfa8bd4fa07231b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/VisualBench/VisualBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/VisualBench/VisualFlags.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualFlags.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
joshualitt
lgtm
5 years, 1 month ago (2015-11-13 15:19:28 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1441073005 Patch 1). Please resolve the dependency and ...
5 years, 1 month ago (2015-11-13 15:55:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444543002/1
5 years, 1 month ago (2015-11-13 16:59:40 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 17:10:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/60795d99fff8caedc2e82bebcfa8bd4fa07231b7

Powered by Google App Engine
This is Rietveld 408576698