Correct UseCounter::FormNameAccessForImageElement.

Correct UseCounter::FormNameAccessForImageElement.

It seems the counter didn't cover form.imageName case.

BUG=555387
R=keishi@chromium.org, sigbjornf@opera.com

Committed: https://chromium.googlesource.com/chromium/src/+/075928d082925a6fa76e8c1c3f49efa2b561ebf3

[tkent, 2015-11-13 08:00:38]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2015-11-13 08:00:38]

Keishi, would you review this please?

[sof, 2015-11-13 08:06:49]

https://codereview.chromium.org/1444533002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/1444533002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLFormElement.cpp:846: bool onlyMatchImg =
!elements.isEmpty() && isHTMLImageElement(*elements.first());
Why not move this flag up a bit & reuse it?

[tkent, 2015-11-13 08:11:10]

https://codereview.chromium.org/1444533002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/1444533002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLFormElement.cpp:846: bool onlyMatchImg =
!elements.isEmpty() && isHTMLImageElement(*elements.first());
On 2015/11/13 at 08:06:48, sof wrote:
> Why not move this flag up a bit & reuse it?

That's a good idea.  Done.

[keishi, 2015-11-13 08:12:02]

LGTM

[tkent, 2015-11-13 08:12:34]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-11-13 08:12:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1444533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1444533002/20001

[sof, 2015-11-13 08:21:48]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2015-11-13 08:21:48]

https://codereview.chromium.org/1444533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/1444533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormElement.cpp:840: if (onlyMatchImg)
Hmm, what if the <img> element doesn't appear first and/or there are multiple
with that id/name?

[tkent, 2015-11-13 08:28:25]

https://codereview.chromium.org/1444533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/1444533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormElement.cpp:840: if (onlyMatchImg)
On 2015/11/13 at 08:21:48, sof wrote:
> Hmm, what if the <img> element doesn't appear first and/or there are multiple
with that id/name?

I'd like to count only cases where this function returns an IMG element or
RadioNodeList with IMG elements. The current code is enough because
RadioNodeList with onlyMatchImg=false won't include IMG elements.

[sof, 2015-11-13 08:33:10]

https://codereview.chromium.org/1444533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/1444533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormElement.cpp:840: if (onlyMatchImg)
On 2015/11/13 08:28:25, tkent wrote:
> On 2015/11/13 at 08:21:48, sof wrote:
> > Hmm, what if the <img> element doesn't appear first and/or there are
multiple
> with that id/name?
> 
> I'd like to count only cases where this function returns an IMG element or
> RadioNodeList with IMG elements. The current code is enough because
> RadioNodeList with onlyMatchImg=false won't include IMG elements.

Yes, this looks correct & precise as-is -- step 2 from
https://html.spec.whatwg.org/multipage/forms.html#dom-form-nameditem will only
return IMGs and never a list with IMGs mixed in. lgtm.

[commit-bot: I haz the power, 2015-11-13 09:08:49]

Patchset 2 (id:??) landed as
https://crrev.com/075928d082925a6fa76e8c1c3f49efa2b561ebf3
Cr-Commit-Position: refs/heads/master@{#359517}

[tkent, 2015-11-13 09:09:23]

Committed patchset #2 (id:20001) manually as
075928d082925a6fa76e8c1c3f49efa2b561ebf3 (presubmit successful).