Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1444523004: Revert of Makes the default French keyboard as fr(oss) XKB layout. (Closed)

Created:
5 years, 1 month ago by Shu Chen
Modified:
5 years, 1 month ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Makes the default French keyboard as fr(oss) XKB layout. (patchset #1 id:1 of https://codereview.chromium.org/1436813009/ ) Reason for revert: Suspect the cause of regression crbug.com/555507. Original issue's description: > Makes the default French keyboard as fr(oss) XKB layout. > > BUG=409835 > TEST=None > TBR=nona@chromium.org > > Committed: https://crrev.com/47e24db9c43a449e2dc3f616b369685af7ecf098 > Cr-Commit-Position: refs/heads/master@{#359495} TBR=nona@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=409835 Committed: https://crrev.com/8805236d36ec0538740829f0d91cb5f9f9fec06f Cr-Commit-Position: refs/heads/master@{#359532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Shu Chen
Created Revert of Makes the default French keyboard as fr(oss) XKB layout.
5 years, 1 month ago (2015-11-13 12:34:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444523004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444523004/1
5 years, 1 month ago (2015-11-13 12:34:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 12:35:37 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 12:36:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8805236d36ec0538740829f0d91cb5f9f9fec06f
Cr-Commit-Position: refs/heads/master@{#359532}

Powered by Google App Engine
This is Rietveld 408576698