Issue 1444413002: Revert of Simplify starting a navigation

Issue 1444413002: Revert of Simplify starting a navigation (Closed)

Created:
5 years, 1 month ago by Nate Chapin

Modified:
5 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, jochen+watch_chromium.org, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, mlamouri+watch-test-runner_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Simplify starting a navigation (patchset #6 id:100001 of https://codereview.chromium.org/1418003006/ ) Reason for revert: This caused several regressions: https://code.google.com/p/chromium/issues/detail?id=555914 https://code.google.com/p/chromium/issues/detail?id=553078 https://code.google.com/p/chromium/issues/detail?id=553493 Original issue's description: > Simplify starting a navigation > > Remove a whole bunch of accumulated technical debt in > DocumentLoader and core/fetch/ related to starting a navigation > and handling redirects. > > BUG= > > Committed: https://crrev.com/83a52878976eaffc8753993a7689c9c178664fba > Cr-Commit-Position: refs/heads/master@{#358420} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/65a9812e8f82bd73e8da2c1865db8d1e81b5d9e7 Cr-Commit-Position: refs/heads/master@{#359864}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -86 lines)			Patch
M	chrome/browser/ssl/ssl_browser_tests.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/http/tests/loading/307-after-303-after-post-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/LayoutTests/http/tests/loading/redirect-methods-expected.txt	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/core/fetch/FetchContext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/fetch/FetchContext.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/fetch/RawResource.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/fetch/RawResource.cpp	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/fetch/Resource.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/fetch/Resource.cpp	View	2 chunks	+21 lines, -11 lines	0 comments	Download
M	third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/fetch/ResourceLoader.h	View	4 chunks	+5 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/fetch/ResourceLoader.cpp	View	3 chunks	+13 lines, -6 lines	0 comments	Download
M	third_party/WebKit/Source/core/loader/DocumentLoader.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/loader/DocumentLoader.cpp	View	4 chunks	+80 lines, -41 lines	0 comments	Download
M	third_party/WebKit/Source/core/loader/FrameFetchContext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/loader/FrameFetchContext.cpp	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/loader/FrameLoader.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444413002/1

5 years, 1 month ago (2015-11-16 18:10:30 UTC) #2

commit-bot: I haz the power

5 years, 1 month ago (2015-11-16 18:13:19 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/65a9812e8f82bd73e8da2c1865db8d1e81b5d9e7
Cr-Commit-Position: refs/heads/master@{#359864}

Expand Messages | Collapse Messages