Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1444173002: third_party/WebKit: fix typos found in comments (Closed)

Created:
5 years, 1 month ago by JakeYoon
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party/WebKit: fix typos found in comments I used misspellings tool (https://pypi.python.org/pypi/misspellings). Misspellings tool find typo errors based on common typo errors. But, because this tool only found typos error from spellings, it is not always correct. So I has checked whether the result of tool correct or not line by line. And this tool find typo errors in source codes also. So I check it also to do not change source code. BUG=None R=jinho.bang@samsung.com

Patch Set 1 #

Total comments: 2

Patch Set 2 : Separate AUTHORS modify and fix typos add #

Patch Set 3 : CL Description updated. #

Patch Set 4 : git reset patchset#2 -> git pull -> git rebase #

Patch Set 5 : CL Description change, Typo patch apply to upstream master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -74 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/npruntime.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RuleSetTest.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventListenerMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindowTimers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutCounter.cpp View 1 2 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 2 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/LinkHeader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.cpp View 1 2 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/MemoryInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/SincResampler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontPlatformDataWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/TextBoundaries.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/RotationViewportAnchor.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 2 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 4 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/DateMath.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/PartitionAlloc.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/dtoa.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 46 (21 generated)
JakeYoon
5 years, 1 month ago (2015-11-15 01:27:06 UTC) #1
tfarina
Please, do not commit this patch with the following in the CL description. "And this ...
5 years, 1 month ago (2015-11-15 01:33:34 UTC) #3
JakeYoon
I will try to use only the kind of information in the CL description. Thanks ...
5 years, 1 month ago (2015-11-15 01:37:37 UTC) #5
JakeYoon
On 2015/11/15 01:33:34, tfarina wrote: > Please, do not commit this patch with the following ...
5 years, 1 month ago (2015-11-15 01:44:01 UTC) #6
JakeYoon
On 2015/11/15 01:44:01, JakeYoon wrote: > On 2015/11/15 01:33:34, tfarina wrote: > > Please, do ...
5 years, 1 month ago (2015-11-15 01:49:16 UTC) #7
zino
looks good but you should wait for owner's review. I think you will be able ...
5 years, 1 month ago (2015-11-16 07:40:35 UTC) #10
haraken
https://codereview.chromium.org/1444173002/diff/1/AUTHORS File AUTHORS (right): https://codereview.chromium.org/1444173002/diff/1/AUTHORS#newcode248 AUTHORS:248: Jake Yoon <yjaeseok@gmail.com> Please make this change separately.
5 years, 1 month ago (2015-11-16 07:46:45 UTC) #12
Yuta Kitamura
https://codereview.chromium.org/1444173002/diff/1/third_party/WebKit/Source/core/frame/Frame.cpp File third_party/WebKit/Source/core/frame/Frame.cpp (right): https://codereview.chromium.org/1444173002/diff/1/third_party/WebKit/Source/core/frame/Frame.cpp#newcode222 third_party/WebKit/Source/core/frame/Frame.cpp:222: // This is the normal case. A document can ...
5 years, 1 month ago (2015-11-16 07:49:47 UTC) #14
JakeYoon
On 2015/11/16 07:49:47, Yuta Kitamura wrote: > https://codereview.chromium.org/1444173002/diff/1/third_party/WebKit/Source/core/frame/Frame.cpp > File third_party/WebKit/Source/core/frame/Frame.cpp (right): > > https://codereview.chromium.org/1444173002/diff/1/third_party/WebKit/Source/core/frame/Frame.cpp#newcode222 ...
5 years, 1 month ago (2015-11-16 08:01:46 UTC) #15
JakeYoon
On 2015/11/16 07:46:45, haraken wrote: > https://codereview.chromium.org/1444173002/diff/1/AUTHORS > File AUTHORS (right): > > https://codereview.chromium.org/1444173002/diff/1/AUTHORS#newcode248 > ...
5 years, 1 month ago (2015-11-16 12:40:27 UTC) #16
tfarina
Why did you remove chromium-reviews from CC list? Please, don't do this. Otherwise things get ...
5 years, 1 month ago (2015-11-16 12:50:36 UTC) #17
tfarina
The CL description still needs polishment. You are basically repeating yourself three times in three ...
5 years, 1 month ago (2015-11-16 12:55:50 UTC) #18
JakeYoon
On 2015/11/16 12:50:36, tfarina wrote: > Why did you remove chromium-reviews from CC list? Please, ...
5 years, 1 month ago (2015-11-16 13:07:47 UTC) #19
JakeYoon
On 2015/11/16 13:07:47, JakeYoon wrote: > On 2015/11/16 12:50:36, tfarina wrote: > > Why did ...
5 years, 1 month ago (2015-11-16 13:19:59 UTC) #20
JakeYoon
On 2015/11/16 12:55:50, tfarina wrote: > The CL description still needs polishment. You are basically ...
5 years, 1 month ago (2015-11-16 13:34:53 UTC) #22
zino
On 2015/11/16 12:50:36, tfarina wrote: > Why did you remove chromium-reviews from CC list? Please, ...
5 years, 1 month ago (2015-11-16 15:35:16 UTC) #24
zino
JakeYoon@, Please rewrite the CL description. Each line should be < 80bytes.
5 years, 1 month ago (2015-11-16 15:41:07 UTC) #25
JakeYoon
On 2015/11/16 15:41:07, zino wrote: > JakeYoon@, > > Please rewrite the CL description. Each ...
5 years, 1 month ago (2015-11-16 20:57:54 UTC) #30
tfarina
On 2015/11/16 20:57:54, JakeYoon wrote: > I modified the CL Description to each line is ...
5 years, 1 month ago (2015-11-16 21:31:07 UTC) #32
JakeYoon
On 2015/11/16 21:31:07, tfarina wrote: > On 2015/11/16 20:57:54, JakeYoon wrote: > > I modified ...
5 years ago (2015-12-01 14:49:27 UTC) #38
zino
On 2015/12/01 14:49:27, JakeYoon wrote: > @tfarlna I am sorry, I think I got in ...
5 years ago (2015-12-02 04:21:02 UTC) #40
JakeYoon
On 2015/12/02 04:21:02, zino wrote: > On 2015/12/01 14:49:27, JakeYoon wrote: > > @tfarlna I ...
5 years ago (2015-12-02 14:22:38 UTC) #41
JakeYoon
On 2015/12/02 14:22:38, JakeYoon wrote: > On 2015/12/02 04:21:02, zino wrote: > > On 2015/12/01 ...
5 years ago (2015-12-17 05:01:17 UTC) #42
JakeYoon
Please review tfarina@, haraken@, Yuta Kitamura@ I am looking forward to your review!
5 years ago (2015-12-20 05:49:43 UTC) #43
JakeYoon
4 years, 11 months ago (2016-01-04 15:28:48 UTC) #46
Please review nednguyen@, Pawel Hajdan Jr.@
I am looking forward to your review!

Powered by Google App Engine
This is Rietveld 408576698