Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 254463004: Cleanup coding style (Closed)

Created:
6 years, 8 months ago by jaeweheo
Modified:
6 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cleanup coding style No logical changes. BUG=

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unnecessary include directives #

Patch Set 3 : Remove unnecessary include directives #

Patch Set 4 : Rebase about crx_file.h modified already. (issue: 225493002) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M AUTHORS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/csp_validator.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/event_filter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/event_filtering_info.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/event_matcher.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/extension_api.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/extension_builder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/extension_messages.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/extension_resource.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/extension_set.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/install_warning.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/manifest_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/stack_frame_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/url_pattern_set.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 39 (0 generated)
jaeweheo
Please review files. Just cleanup coding style by using cpplint.py Thank you.
6 years, 8 months ago (2014-04-24 16:00:46 UTC) #1
nasko
I'm not an OWNER of extensions/, just IPC messages. You will need someone to review ...
6 years, 8 months ago (2014-04-24 22:49:08 UTC) #2
jaeweheo
On 2014/04/24 22:49:08, nasko wrote: > I'm not an OWNER of extensions/, just IPC messages. ...
6 years, 8 months ago (2014-04-25 00:04:17 UTC) #3
jaeweheo
Please review files. Just cleanup coding style by using cpplint.py Thank you.
6 years, 8 months ago (2014-04-25 00:06:30 UTC) #4
Devlin
Mostly good! Thanks for the cleanup! https://codereview.chromium.org/254463004/diff/1/extensions/common/extension_messages.cc File extensions/common/extension_messages.cc (right): https://codereview.chromium.org/254463004/diff/1/extensions/common/extension_messages.cc#newcode5 extensions/common/extension_messages.cc:5: #include <set> Nit: ...
6 years, 8 months ago (2014-04-25 00:14:54 UTC) #5
jaeweheo
Please review again. Removed unnecessary include directives. Thank you for your time. https://codereview.chromium.org/254463004/diff/1/extensions/common/extension_messages.cc File extensions/common/extension_messages.cc ...
6 years, 8 months ago (2014-04-25 01:48:55 UTC) #6
Devlin
LGTM! Thanks for the cleanup!
6 years, 8 months ago (2014-04-25 15:54:07 UTC) #7
jaeweheo
The CQ bit was checked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-25 15:54:55 UTC) #8
jaeweheo
The CQ bit was unchecked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-25 15:55:17 UTC) #9
jaeweheo
The CQ bit was checked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-25 15:55:40 UTC) #10
jaeweheo
The CQ bit was unchecked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-25 16:03:21 UTC) #11
jaeweheo
The CQ bit was checked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-25 16:03:22 UTC) #12
jaeweheo
The CQ bit was unchecked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-25 16:03:31 UTC) #13
jaeweheo
The CQ bit was checked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-25 16:03:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaeweheo@gmail.com/254463004/40001
6 years, 8 months ago (2014-04-25 22:16:21 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 22:16:29 UTC) #16
commit-bot: I haz the power
Failed to apply patch for extensions/common/crx_file.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-25 22:16:29 UTC) #17
jaeweheo
The CQ bit was checked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-26 01:04:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaeweheo@gmail.com/254463004/40001
6 years, 8 months ago (2014-04-26 01:05:21 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 01:05:29 UTC) #20
commit-bot: I haz the power
Failed to apply patch for extensions/common/crx_file.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-26 01:05:29 UTC) #21
jaeweheo
The CQ bit was checked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-26 01:48:43 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaeweheo@gmail.com/254463004/40001
6 years, 8 months ago (2014-04-26 02:03:56 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 02:04:19 UTC) #24
commit-bot: I haz the power
Failed to apply patch for extensions/common/crx_file.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-26 02:04:19 UTC) #25
jaeweheo
Thanks for LGTM. But failed to commit. So I Just rebased my CL. Please review ...
6 years, 8 months ago (2014-04-26 04:28:30 UTC) #26
jaeweheo
The CQ bit was checked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-26 04:38:59 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaeweheo@gmail.com/254463004/60001
6 years, 8 months ago (2014-04-26 04:39:57 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 05:17:25 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-26 05:17:25 UTC) #30
jaeweheo
The CQ bit was checked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-26 05:23:04 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaeweheo@gmail.com/254463004/60001
6 years, 8 months ago (2014-04-26 05:23:45 UTC) #32
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 06:07:14 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-26 06:07:15 UTC) #34
jaeweheo
The CQ bit was checked by jaeweheo@gmail.com
6 years, 8 months ago (2014-04-26 07:53:41 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaeweheo@gmail.com/254463004/60001
6 years, 8 months ago (2014-04-26 07:55:07 UTC) #36
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 08:43:07 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-26 08:43:08 UTC) #38
jaeweheo
6 years, 8 months ago (2014-04-26 08:58:48 UTC) #39
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/258823006/ by jaeweheo@gmail.com.

The reason for reverting is: Someone already cleanup some files..

Powered by Google App Engine
This is Rietveld 408576698