Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1443963004: use strip instead of lstrip + rstrip (Closed)

Created:
5 years, 1 month ago by thefourtheye
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] gen-postmortem-metadata: use strip instead of lstrip + rstrip In Python, `strip` can be used directly instead of stripping the ends one by one. R=machenbach@chromium.org NOTRY=true Committed: https://crrev.com/c0ec16e5593f5457b75d445e98cf02fd13a5efc1 Cr-Commit-Position: refs/heads/master@{#32413}

Patch Set 1 #

Patch Set 2 : adding reviewers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/gen-postmortem-metadata.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
thefourtheye
5 years, 1 month ago (2015-11-14 03:40:18 UTC) #1
Jakob Kummerow
rubberstamp LGTM
5 years, 1 month ago (2015-11-16 10:41:53 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443963004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443963004/20001
5 years, 1 month ago (2015-11-16 13:01:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-16 13:35:21 UTC) #8
thefourtheye
On 2015/11/16 13:35:21, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-11-30 16:15:52 UTC) #9
Jakob Kummerow
On 2015/11/30 16:15:52, thefourtheye wrote: > Any update? Why'd you do a dry run and ...
5 years ago (2015-11-30 17:04:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443963004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443963004/20001
5 years ago (2015-11-30 17:04:51 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-30 17:07:51 UTC) #15
commit-bot: I haz the power
5 years ago (2015-11-30 17:08:02 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0ec16e5593f5457b75d445e98cf02fd13a5efc1
Cr-Commit-Position: refs/heads/master@{#32413}

Powered by Google App Engine
This is Rietveld 408576698