Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1443963004:
use strip instead of lstrip + rstrip (Closed)
|
Created:
5 years, 1 month ago by thefourtheye Modified:
5 years ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[tools] gen-postmortem-metadata: use strip instead of lstrip + rstrip
In Python, `strip` can be used directly instead of stripping the ends
one by one.
R=machenbach@chromium.org
NOTRY=true
Committed: https://crrev.com/c0ec16e5593f5457b75d445e98cf02fd13a5efc1
Cr-Commit-Position: refs/heads/master@{#32413}
Patch Set 1 #Patch Set 2 : adding reviewers #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== use strip instead of lstrip + rstrip In Python, `strip` can be used directly instead of stripping the ends one by one. R=machenbach@chromium.org BUG= ========== to ========== [tools] gen-postmortem-metadata: use strip instead of lstrip + rstrip In Python, `strip` can be used directly instead of stripping the ends one by one. R=machenbach@chromium.org BUG= ==========
jkummerow@chromium.org changed reviewers: + jkummerow@chromium.org
rubberstamp LGTM
The CQ bit was checked by thechargingvolcano@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443963004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443963004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2015/11/16 13:35:21, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. Any update?
On 2015/11/30 16:15:52, thefourtheye wrote: > Any update? Why'd you do a dry run and then not commit it? Also, it's not like there's any test coverage for that script, so running try jobs is a waste of resources.
Description was changed from ========== [tools] gen-postmortem-metadata: use strip instead of lstrip + rstrip In Python, `strip` can be used directly instead of stripping the ends one by one. R=machenbach@chromium.org BUG= ========== to ========== [tools] gen-postmortem-metadata: use strip instead of lstrip + rstrip In Python, `strip` can be used directly instead of stripping the ends one by one. R=machenbach@chromium.org NOTRY=true ==========
The CQ bit was checked by jkummerow@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443963004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443963004/20001
Message was sent while issue was closed.
Description was changed from ========== [tools] gen-postmortem-metadata: use strip instead of lstrip + rstrip In Python, `strip` can be used directly instead of stripping the ends one by one. R=machenbach@chromium.org NOTRY=true ========== to ========== [tools] gen-postmortem-metadata: use strip instead of lstrip + rstrip In Python, `strip` can be used directly instead of stripping the ends one by one. R=machenbach@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [tools] gen-postmortem-metadata: use strip instead of lstrip + rstrip In Python, `strip` can be used directly instead of stripping the ends one by one. R=machenbach@chromium.org NOTRY=true ========== to ========== [tools] gen-postmortem-metadata: use strip instead of lstrip + rstrip In Python, `strip` can be used directly instead of stripping the ends one by one. R=machenbach@chromium.org NOTRY=true Committed: https://crrev.com/c0ec16e5593f5457b75d445e98cf02fd13a5efc1 Cr-Commit-Position: refs/heads/master@{#32413} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c0ec16e5593f5457b75d445e98cf02fd13a5efc1 Cr-Commit-Position: refs/heads/master@{#32413} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
