tools/gen-postmortem-metadata.py - Issue 1443963004: use strip instead of lstrip + rstrip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gen-postmortem-metadata.py

Issue 1443963004: use strip instead of lstrip + rstrip (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: adding reviewers Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gen-postmortem-metadata.py

diff --git a/tools/gen-postmortem-metadata.py b/tools/gen-postmortem-metadata.py

index 1f2c4e7cbed7a5352efc41b9df5c9937d3ee3d61..4b56a4baebb432329a17dcb70caa9624210ed9db 100644

--- a/tools/gen-postmortem-metadata.py

+++ b/tools/gen-postmortem-metadata.py

@@ -319,7 +319,7 @@ def load_objects():

in_insttype = False;

continue;

- line = re.sub('//.*', '', line.rstrip().lstrip());

+ line = re.sub('//.*', '', line.strip());

if (in_insttype):

typestr += line;

@@ -329,10 +329,10 @@ def load_objects():

line);

if (match):

- klass = match.group(1).rstrip().lstrip();

+ klass = match.group(1).strip();

pklass = match.group(3);

if (pklass):

- pklass = pklass.rstrip().lstrip();

+ pklass = pklass.strip();

klasses[klass] = { 'parent': pklass };

« no previous file with comments | « no previous file | no next file » | no next file with comments »