Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1443763002: Increase the amount of debug information printed out by batches (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Increase the amount of debug information printed out by batches Untangling MDB bugs requires more information. In particular the render targets. BUG=skia:4094 TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/e004bfc0a5e28cc083158f1a75e981ffd58a8134

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 2

Patch Set 3 : Fixed overlength line #

Patch Set 4 : Fix printf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -8 lines) Patch
M include/gpu/GrProcessor.h View 2 chunks +8 lines, -0 lines 0 comments Download
M include/gpu/effects/GrConstColorProcessor.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M src/gpu/batches/GrClearBatch.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDiscardBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawBatch.h View 1 chunk +7 lines, -2 lines 0 comments Download
M src/gpu/batches/GrNonAAFillRectBatch.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M src/gpu/batches/GrTInstanceBatch.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/effects/Gr1DKernelEffect.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 chunk +7 lines, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
robertphillips
5 years, 1 month ago (2015-11-13 19:39:58 UTC) #4
joshualitt
lgtm + nit https://codereview.chromium.org/1443763002/diff/40001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/1443763002/diff/40001/src/gpu/GrOvalRenderer.cpp#newcode632 src/gpu/GrOvalRenderer.cpp:632: string.appendf("Color: 0x%08x Rect [L: %.2f, T: ...
5 years, 1 month ago (2015-11-13 19:43:24 UTC) #6
robertphillips
https://codereview.chromium.org/1443763002/diff/40001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/1443763002/diff/40001/src/gpu/GrOvalRenderer.cpp#newcode632 src/gpu/GrOvalRenderer.cpp:632: string.appendf("Color: 0x%08x Rect [L: %.2f, T: %.2f, R: %.2f, ...
5 years, 1 month ago (2015-11-16 14:16:06 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443763002/60001
5 years, 1 month ago (2015-11-16 14:26:16 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/4229)
5 years, 1 month ago (2015-11-16 14:27:05 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443763002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443763002/80001
5 years, 1 month ago (2015-11-16 14:38:27 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-16 14:50:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443763002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443763002/80001
5 years, 1 month ago (2015-11-16 16:23:02 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3906)
5 years, 1 month ago (2015-11-16 16:24:07 UTC) #20
robertphillips
Adding Brian for interface
5 years, 1 month ago (2015-11-16 16:26:40 UTC) #23
bsalomon
lgtm
5 years, 1 month ago (2015-11-16 16:44:51 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443763002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443763002/80001
5 years, 1 month ago (2015-11-16 17:06:26 UTC) #26
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 17:07:02 UTC) #27
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) as
https://skia.googlesource.com/skia/+/e004bfc0a5e28cc083158f1a75e981ffd58a8134

Powered by Google App Engine
This is Rietveld 408576698