Split ValidateAndApplyPropertyDescriptor out of OrdinaryDefineOwnProperty

Split ValidateAndApplyPropertyDescriptor out of OrdinaryDefineOwnProperty

In preparation for JSProxy::GetOwnProperty.

R=cbruni@chromium.org

Committed: https://crrev.com/b9760afead06458126fb3b82ef30cf10d021a9d2
Cr-Commit-Position: refs/heads/master@{#31990}

[Jakob Kummerow, 2015-11-13 16:08:55]

PTAL. This is just refactoring (and introduction of a trivial entry point that's
not used yet: IsCompatiblePropertyDescriptor), no change in existing behavior is
intended.

[Camillo Bruni, 2015-11-13 16:35:43]

LGTM with irrelevant nit.

https://codereview.chromium.org/1443683003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1443683003/diff/1/src/objects.cc#newcode6232
src/objects.cc:6232: it != NULL ? it->GetName() : property_name));
myabe directly assign the propert_name from the lookup iterator at the method
start.

[Jakob Kummerow, 2015-11-13 16:37:49]

Thanks, landing.

https://codereview.chromium.org/1443683003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1443683003/diff/1/src/objects.cc#newcode6232
src/objects.cc:6232: it != NULL ? it->GetName() : property_name));
On 2015/11/13 16:35:43, cbruni wrote:
> myabe directly assign the propert_name from the lookup iterator at the method
> start.

As discussed, GetName() is intentionally only called on the error path, because
it may have to allocate a string (if we only had an element index before).

[Jakob Kummerow, 2015-11-13 16:37:52]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2015-11-13 16:37:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1443683003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1443683003/1

[commit-bot: I haz the power, 2015-11-13 17:18:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-14 23:21:46]

Patchset 1 (id:??) landed as
https://crrev.com/b9760afead06458126fb3b82ef30cf10d021a9d2
Cr-Commit-Position: refs/heads/master@{#31990}