Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: src/objects.h

Issue 1443683003: Split ValidateAndApplyPropertyDescriptor out of OrdinaryDefineOwnProperty (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 94af73b0ab8b11ebcdde69bc1781b05e6dd77350..2e346260975286808fdc0ddb0047e0e4b6604581 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1843,6 +1843,7 @@ class JSReceiver: public HeapObject {
Handle<Object> key, PropertyDescriptor* desc,
ShouldThrow should_throw);
+ // ES6 9.1.6.1
static bool OrdinaryDefineOwnProperty(Isolate* isolate,
Handle<JSObject> object,
Handle<Object> key,
@@ -1851,6 +1852,18 @@ class JSReceiver: public HeapObject {
static bool OrdinaryDefineOwnProperty(LookupIterator* it,
PropertyDescriptor* desc,
ShouldThrow should_throw);
+ // ES6 9.1.6.2
+ static bool IsCompatiblePropertyDescriptor(bool extensible,
+ PropertyDescriptor* desc,
+ PropertyDescriptor* current,
+ Handle<Name> property_name);
+ // ES6 9.1.6.3
+ // |it| can be NULL in cases where the ES spec passes |undefined| as the
+ // receiver. Exactly one of |it| and |property_name| must be provided.
+ static bool ValidateAndApplyPropertyDescriptor(
+ LookupIterator* it, bool extensible, PropertyDescriptor* desc,
+ PropertyDescriptor* current, ShouldThrow should_throw,
+ Handle<Name> property_name = Handle<Name>());
static bool GetOwnPropertyDescriptor(Isolate* isolate,
Handle<JSReceiver> object,
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698