Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1443663004: Don't propagate deps across actions in GN. (Closed)

Created:
5 years, 1 month ago by brettw
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't propagate deps across actions in GN. This change makes library propagation stop at actions and copy rules. This allows actions to take libraries as inputs without forcing dependants to also link to them. It's not normal to have an action or copy rule where you want to propagate such libraries. Enhance the deps documentation to discuss propagation. Remove Android hack around an old STL. Our Android builds use a newer STL now. Update reference.md Committed: https://crrev.com/374d4fdda798f67627ee4179e365fc96f5abadd7 Cr-Commit-Position: refs/heads/master@{#359707}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -42 lines) Patch
M tools/gn/docs/reference.md View 1 2 3 16 chunks +119 lines, -24 lines 0 comments Download
M tools/gn/target.h View 1 chunk +3 lines, -1 line 0 comments Download
M tools/gn/target.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download
M tools/gn/target_unittest.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
M tools/gn/variables.cc View 1 2 chunks +26 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
brettw
5 years, 1 month ago (2015-11-13 20:47:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443663004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443663004/40001
5 years, 1 month ago (2015-11-13 20:48:56 UTC) #4
Dirk Pranke
Seems reasonable. Can you update //tools/gn/docs/reference.md , either in this patch or a separate one, ...
5 years, 1 month ago (2015-11-13 20:52:29 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443663004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443663004/60001
5 years, 1 month ago (2015-11-13 21:01:19 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 21:18:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443663004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443663004/60001
5 years, 1 month ago (2015-11-14 00:21:20 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-14 00:57:13 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 00:58:02 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/374d4fdda798f67627ee4179e365fc96f5abadd7
Cr-Commit-Position: refs/heads/master@{#359707}

Powered by Google App Engine
This is Rietveld 408576698