Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: tools/gn/target.h

Issue 1443663004: Don't propagate deps across actions in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/docs/reference.md ('k') | tools/gn/target.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.h
diff --git a/tools/gn/target.h b/tools/gn/target.h
index 383a2af08368747ded8c3e6822ff2de4e384de76..10d3b05dd992ed1be07bb2a0a02248f4205b9793 100644
--- a/tools/gn/target.h
+++ b/tools/gn/target.h
@@ -68,7 +68,9 @@ class Target : public Item {
// Can be linked into other targets.
bool IsLinkable() const;
- // Can have dependencies linked in.
+ // True if the target links dependencies rather than propogated up the graph.
+ // This is also true of action and copy steps even though they don't link
+ // dependencies, because they also don't propogate libraries up.
bool IsFinal() const;
// Will be the empty string to use the target label as the output name.
« no previous file with comments | « tools/gn/docs/reference.md ('k') | tools/gn/target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698