Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1440313003: Allow higher unicode characters in XMB files. (Closed)

Created:
5 years, 1 month ago by newt (away)
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow higher unicode characters in XMB files. The XMB tool has a regex of invalid XML characters, which erroneously contained all unicode characters in the supplementary planes (U+10000 to U+10FFFF). The tool would silently replace these characters with spaces when generating XMB files, which caused problems recently when an emoji character was added to a grd file. The translation console supports these characters, so GRIT should too. The XMB tool now supports these characters, and now raises an exception if an invalid character is used (instead of silently replacing it with a space). BUG=498288 Committed: https://crrev.com/96a915e2679355c93d458699c49b365f0a05c27d Cr-Commit-Position: refs/heads/master@{#359621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M tools/grit/grit/tool/xmb.py View 2 chunks +8 lines, -2 lines 0 comments Download
M tools/grit/grit/tool/xmb_unittest.py View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
newt (away)
PTAL (third time's the charm)
5 years, 1 month ago (2015-11-13 17:48:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440313003/1
5 years, 1 month ago (2015-11-13 17:49:18 UTC) #4
Nico
lgtm
5 years, 1 month ago (2015-11-13 17:59:07 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 19:13:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440313003/1
5 years, 1 month ago (2015-11-13 19:21:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 20:26:53 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 20:28:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96a915e2679355c93d458699c49b365f0a05c27d
Cr-Commit-Position: refs/heads/master@{#359621}

Powered by Google App Engine
This is Rietveld 408576698