Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1443453002: [Sync] Move sessions files from sync_driver to sync_sessions. (Closed)

Created:
5 years, 1 month ago by maxbogue
Modified:
5 years, 1 month ago
Reviewers:
Nicolas Zea, jam
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, zea+watch_chromium.org, blundell+watchlist_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Move sessions files from sync_driver to sync_sessions. The sync team has decided that datatype specific code should no longer live in sync_driver. //c/sync_driver will conceptually be at the same level as //sync in the dependency tree, with datatype logic living in special components such as sync_sessions or the datatype components themselves. BUG=543199 TBR=jam Committed: https://crrev.com/8ef2508962ebddf75fe5ec3e7b8284293df733d4 Cr-Commit-Position: refs/heads/master@{#359886}

Patch Set 1 #

Patch Set 2 : Try fixing Android and iOS. #

Patch Set 3 : Run formatter. #

Total comments: 2

Patch Set 4 : Remove ui/gfx deps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -1094 lines) Patch
M chrome/browser/android/favicon_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/foreign_session_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_sync_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_window_delegate_android.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_window_delegates_getter_android.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_window_delegates_getter_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sessions_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sessions_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/browser_synced_window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/browser_synced_window_delegates_getter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/browser_synced_window_delegates_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/foreign_session_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 2 chunks +1 line, -1 line 0 comments Download
M components/sync_driver.gypi View 1 2 3 5 chunks +0 lines, -19 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 2 3 7 chunks +0 lines, -13 lines 0 comments Download
M components/sync_driver/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/sync_driver/glue/synced_session.h View 1 chunk +0 lines, -94 lines 0 comments Download
D components/sync_driver/glue/synced_session.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D components/sync_driver/glue/synced_window_delegate.h View 1 chunk +0 lines, -70 lines 0 comments Download
D components/sync_driver/open_tabs_ui_delegate.h View 1 chunk +0 lines, -70 lines 0 comments Download
D components/sync_driver/open_tabs_ui_delegate.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/sync_driver/sessions/synced_window_delegates_getter.h View 1 chunk +0 lines, -36 lines 0 comments Download
D components/sync_driver/sessions/synced_window_delegates_getter.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D components/sync_driver/tab_node_pool.h View 1 chunk +0 lines, -164 lines 0 comments Download
D components/sync_driver/tab_node_pool.cc View 1 chunk +0 lines, -188 lines 0 comments Download
D components/sync_driver/tab_node_pool_unittest.cc View 1 chunk +0 lines, -263 lines 0 comments Download
M components/sync_sessions.gypi View 2 chunks +9 lines, -0 lines 0 comments Download
M components/sync_sessions/BUILD.gn View 3 chunks +10 lines, -0 lines 0 comments Download
A + components/sync_sessions/open_tabs_ui_delegate.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sync_sessions/open_tabs_ui_delegate.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync_sessions/revisit/sessions_page_revisit_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/session_data_type_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_sessions/session_data_type_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_sessions/sessions_sync_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync_sessions/sessions_sync_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sync_sessions/synced_session.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + components/sync_sessions/synced_session.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync_sessions/synced_session_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sync_sessions/synced_window_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync_sessions/synced_window_delegates_getter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync_sessions/synced_window_delegates_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync_sessions/tab_node_pool.h View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
A + components/sync_sessions/tab_node_pool.cc View 1 2 10 chunks +19 lines, -25 lines 0 comments Download
A + components/sync_sessions/tab_node_pool_unittest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_synced_tab_delegate.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
maxbogue
Hey Nicolas, PTAL! I think the only datatype dependencies left in sync_driver after this are ...
5 years, 1 month ago (2015-11-13 00:30:59 UTC) #3
Nicolas Zea
LGTM with one comment https://codereview.chromium.org/1443453002/diff/40001/components/sync_driver.gypi File components/sync_driver.gypi (right): https://codereview.chromium.org/1443453002/diff/40001/components/sync_driver.gypi#newcode17 components/sync_driver.gypi:17: '../ui/gfx/gfx.gyp:gfx', Can this one be ...
5 years, 1 month ago (2015-11-13 23:34:55 UTC) #4
maxbogue
https://codereview.chromium.org/1443453002/diff/40001/components/sync_driver.gypi File components/sync_driver.gypi (right): https://codereview.chromium.org/1443453002/diff/40001/components/sync_driver.gypi#newcode17 components/sync_driver.gypi:17: '../ui/gfx/gfx.gyp:gfx', On 2015/11/13 23:34:55, Nicolas Zea wrote: > Can ...
5 years, 1 month ago (2015-11-14 01:44:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443453002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443453002/60001
5 years, 1 month ago (2015-11-14 01:44:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/118647)
5 years, 1 month ago (2015-11-14 01:58:26 UTC) #10
maxbogue
+TBR jam for include changes in: chrome/browser/android/* chrome/browser/extensions/* chrome/browser/ui/* ios/*
5 years, 1 month ago (2015-11-16 18:06:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443453002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443453002/60001
5 years, 1 month ago (2015-11-16 18:07:48 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-16 19:10:07 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 19:10:59 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8ef2508962ebddf75fe5ec3e7b8284293df733d4
Cr-Commit-Position: refs/heads/master@{#359886}

Powered by Google App Engine
This is Rietveld 408576698