Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: components/sync_driver/tab_node_pool_unittest.cc

Issue 1443453002: [Sync] Move sessions files from sync_driver to sync_sessions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove ui/gfx deps. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync_driver/tab_node_pool.cc ('k') | components/sync_sessions.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/sync_driver/tab_node_pool.h"
6
7 #include <vector>
8
9 #include "sync/api/sync_change.h"
10 #include "sync/protocol/session_specifics.pb.h"
11 #include "sync/protocol/sync.pb.h"
12 #include "testing/gtest/include/gtest/gtest.h"
13
14 namespace browser_sync {
15
16 class SyncTabNodePoolTest : public testing::Test {
17 protected:
18 SyncTabNodePoolTest() { pool_.SetMachineTag("tag"); }
19
20 int GetMaxUsedTabNodeId() const { return pool_.max_used_tab_node_id_; }
21
22 void AddFreeTabNodes(size_t size, const int node_ids[]);
23
24 TabNodePool pool_;
25 };
26
27 void SyncTabNodePoolTest::AddFreeTabNodes(
28 size_t size, const int node_ids[]) {
29 for (size_t i = 0; i < size; ++i) {
30 pool_.free_nodes_pool_.insert(node_ids[i]);
31 }
32 }
33
34 namespace {
35
36 TEST_F(SyncTabNodePoolTest, TabNodeIdIncreases) {
37 syncer::SyncChangeList changes;
38 // max_used_tab_node_ always increases.
39 pool_.AddTabNode(10);
40 EXPECT_EQ(10, GetMaxUsedTabNodeId());
41 pool_.AddTabNode(5);
42 EXPECT_EQ(10, GetMaxUsedTabNodeId());
43 pool_.AddTabNode(1000);
44 EXPECT_EQ(1000, GetMaxUsedTabNodeId());
45 pool_.ReassociateTabNode(1000, 1);
46 pool_.ReassociateTabNode(5, 2);
47 pool_.ReassociateTabNode(10, 3);
48 // Freeing a tab node does not change max_used_tab_node_id_.
49 pool_.FreeTabNode(1000, &changes);
50 EXPECT_TRUE(changes.empty());
51 pool_.FreeTabNode(5, &changes);
52 EXPECT_TRUE(changes.empty());
53 pool_.FreeTabNode(10, &changes);
54 EXPECT_TRUE(changes.empty());
55 for (int i = 0; i < 3; ++i) {
56 pool_.AssociateTabNode(pool_.GetFreeTabNode(&changes), i + 1);
57 EXPECT_EQ(1000, GetMaxUsedTabNodeId());
58 }
59 EXPECT_TRUE(changes.empty());
60 EXPECT_EQ(1000, GetMaxUsedTabNodeId());
61 EXPECT_TRUE(pool_.Empty());
62 }
63
64 TEST_F(SyncTabNodePoolTest, OldTabNodesAddAndRemove) {
65 syncer::SyncChangeList changes;
66 // VerifyOldTabNodes are added.
67 pool_.AddTabNode(1);
68 pool_.AddTabNode(2);
69 EXPECT_EQ(2u, pool_.Capacity());
70 EXPECT_TRUE(pool_.Empty());
71 EXPECT_TRUE(pool_.IsUnassociatedTabNode(1));
72 EXPECT_TRUE(pool_.IsUnassociatedTabNode(2));
73 pool_.ReassociateTabNode(1, 2);
74 EXPECT_TRUE(pool_.Empty());
75 pool_.AssociateTabNode(2, 3);
76 EXPECT_FALSE(pool_.IsUnassociatedTabNode(1));
77 EXPECT_FALSE(pool_.IsUnassociatedTabNode(2));
78 pool_.FreeTabNode(2, &changes);
79 EXPECT_TRUE(changes.empty());
80 // 2 should be returned to free node pool_.
81 EXPECT_EQ(2u, pool_.Capacity());
82 // Should be able to free 1.
83 pool_.FreeTabNode(1, &changes);
84 EXPECT_FALSE(pool_.Empty());
85 EXPECT_TRUE(pool_.Full());
86 EXPECT_EQ(1, pool_.GetFreeTabNode(&changes));
87 EXPECT_TRUE(changes.empty());
88 pool_.AssociateTabNode(1, 1);
89 EXPECT_EQ(2, pool_.GetFreeTabNode(&changes));
90 EXPECT_TRUE(changes.empty());
91 pool_.AssociateTabNode(2, 1);
92 EXPECT_TRUE(pool_.Empty());
93 EXPECT_FALSE(pool_.Full());
94 EXPECT_FALSE(pool_.Full());
95 }
96
97 TEST_F(SyncTabNodePoolTest, OldTabNodesReassociation) {
98 // VerifyOldTabNodes are reassociated correctly.
99 pool_.AddTabNode(4);
100 pool_.AddTabNode(5);
101 pool_.AddTabNode(6);
102 EXPECT_EQ(3u, pool_.Capacity());
103 EXPECT_TRUE(pool_.Empty());
104 EXPECT_TRUE(pool_.IsUnassociatedTabNode(4));
105 pool_.ReassociateTabNode(4, 5);
106 pool_.AssociateTabNode(5, 6);
107 pool_.AssociateTabNode(6, 7);
108 // Free 5 and 6.
109 syncer::SyncChangeList changes;
110 pool_.FreeTabNode(5, &changes);
111 pool_.FreeTabNode(6, &changes);
112 EXPECT_TRUE(changes.empty());
113 // 5 and 6 nodes should not be unassociated.
114 EXPECT_FALSE(pool_.IsUnassociatedTabNode(5));
115 EXPECT_FALSE(pool_.IsUnassociatedTabNode(6));
116 // Free node pool should have 5 and 6.
117 EXPECT_FALSE(pool_.Empty());
118 EXPECT_EQ(3u, pool_.Capacity());
119
120 // Free all nodes
121 pool_.FreeTabNode(4, &changes);
122 EXPECT_TRUE(changes.empty());
123 EXPECT_TRUE(pool_.Full());
124 std::set<int> free_sync_ids;
125 for (int i = 0; i < 3; ++i) {
126 free_sync_ids.insert(pool_.GetFreeTabNode(&changes));
127 // GetFreeTabNode will return the same value till the node is
128 // reassociated.
129 pool_.AssociateTabNode(pool_.GetFreeTabNode(&changes), i + 1);
130 }
131
132 EXPECT_TRUE(pool_.Empty());
133 EXPECT_EQ(3u, free_sync_ids.size());
134 EXPECT_EQ(1u, free_sync_ids.count(4));
135 EXPECT_EQ(1u, free_sync_ids.count(5));
136 EXPECT_EQ(1u, free_sync_ids.count(6));
137 }
138
139 TEST_F(SyncTabNodePoolTest, Init) {
140 EXPECT_TRUE(pool_.Empty());
141 EXPECT_TRUE(pool_.Full());
142 }
143
144 TEST_F(SyncTabNodePoolTest, AddGet) {
145 syncer::SyncChangeList changes;
146 int free_nodes[] = {5, 10};
147 AddFreeTabNodes(2, free_nodes);
148
149 EXPECT_EQ(2U, pool_.Capacity());
150 EXPECT_EQ(5, pool_.GetFreeTabNode(&changes));
151 pool_.AssociateTabNode(5, 1);
152 EXPECT_FALSE(pool_.Empty());
153 EXPECT_FALSE(pool_.Full());
154 EXPECT_EQ(2U, pool_.Capacity());
155 // 5 is now used, should return 10.
156 EXPECT_EQ(10, pool_.GetFreeTabNode(&changes));
157 }
158
159 TEST_F(SyncTabNodePoolTest, All) {
160 syncer::SyncChangeList changes;
161 EXPECT_TRUE(pool_.Empty());
162 EXPECT_TRUE(pool_.Full());
163 EXPECT_EQ(0U, pool_.Capacity());
164
165 // GetFreeTabNode returns the lowest numbered free node.
166 EXPECT_EQ(0, pool_.GetFreeTabNode(&changes));
167 EXPECT_EQ(1U, changes.size());
168 EXPECT_FALSE(pool_.Empty());
169 EXPECT_TRUE(pool_.Full());
170 EXPECT_EQ(1U, pool_.Capacity());
171
172 // Associate 5, next free node should be 10.
173 pool_.AssociateTabNode(0, 1);
174 EXPECT_EQ(1, pool_.GetFreeTabNode(&changes));
175 EXPECT_EQ(2U, changes.size());
176 changes.clear();
177 pool_.AssociateTabNode(1, 2);
178 EXPECT_TRUE(pool_.Empty());
179 EXPECT_FALSE(pool_.Full());
180 EXPECT_EQ(2U, pool_.Capacity());
181 // Release them in reverse order.
182 pool_.FreeTabNode(1, &changes);
183 pool_.FreeTabNode(0, &changes);
184 EXPECT_EQ(2U, pool_.Capacity());
185 EXPECT_FALSE(pool_.Empty());
186 EXPECT_TRUE(pool_.Full());
187 EXPECT_EQ(0, pool_.GetFreeTabNode(&changes));
188 EXPECT_TRUE(changes.empty());
189 EXPECT_FALSE(pool_.Empty());
190 EXPECT_TRUE(pool_.Full());
191 EXPECT_EQ(2U, pool_.Capacity());
192 EXPECT_FALSE(pool_.Empty());
193 EXPECT_TRUE(pool_.Full());
194 pool_.AssociateTabNode(0, 1);
195 EXPECT_EQ(2U, pool_.Capacity());
196 EXPECT_EQ(1, pool_.GetFreeTabNode(&changes));
197 EXPECT_TRUE(changes.empty());
198 pool_.AssociateTabNode(1, 2);
199 EXPECT_TRUE(pool_.Empty());
200 EXPECT_FALSE(pool_.Full());
201 EXPECT_EQ(2U, pool_.Capacity());
202 // Release them again.
203 pool_.FreeTabNode(1, &changes);
204 pool_.FreeTabNode(0, &changes);
205 EXPECT_FALSE(pool_.Empty());
206 EXPECT_TRUE(pool_.Full());
207 EXPECT_EQ(2U, pool_.Capacity());
208 pool_.Clear();
209 EXPECT_TRUE(pool_.Empty());
210 EXPECT_TRUE(pool_.Full());
211 EXPECT_EQ(0U, pool_.Capacity());
212 }
213
214 TEST_F(SyncTabNodePoolTest, GetFreeTabNodeCreate) {
215 syncer::SyncChangeList changes;
216 EXPECT_EQ(0, pool_.GetFreeTabNode(&changes));
217 EXPECT_TRUE(changes[0].IsValid());
218 EXPECT_EQ(syncer::SyncChange::ACTION_ADD, changes[0].change_type());
219 EXPECT_TRUE(changes[0].sync_data().IsValid());
220 sync_pb::EntitySpecifics entity = changes[0].sync_data().GetSpecifics();
221 sync_pb::SessionSpecifics specifics(entity.session());
222 EXPECT_EQ(0, specifics.tab_node_id());
223 }
224
225 TEST_F(SyncTabNodePoolTest, TabPoolFreeNodeLimits) {
226 // Allocate TabNodePool::kFreeNodesHighWatermark + 1 nodes and verify that
227 // freeing the last node reduces the free node pool size to
228 // kFreeNodesLowWatermark.
229 syncer::SyncChangeList changes;
230 SessionID session_id;
231 std::vector<int> used_sync_ids;
232 for (size_t i = 1; i <= TabNodePool::kFreeNodesHighWatermark + 1; ++i) {
233 session_id.set_id(i);
234 int sync_id = pool_.GetFreeTabNode(&changes);
235 pool_.AssociateTabNode(sync_id, i);
236 used_sync_ids.push_back(sync_id);
237 }
238
239 // Free all except one node.
240 int last_sync_id = used_sync_ids.back();
241 used_sync_ids.pop_back();
242
243 for (size_t i = 0; i < used_sync_ids.size(); ++i) {
244 pool_.FreeTabNode(used_sync_ids[i], &changes);
245 }
246
247 // Except one node all nodes should be in FreeNode pool.
248 EXPECT_FALSE(pool_.Full());
249 EXPECT_FALSE(pool_.Empty());
250 // Total capacity = 1 Associated Node + kFreeNodesHighWatermark free node.
251 EXPECT_EQ(TabNodePool::kFreeNodesHighWatermark + 1, pool_.Capacity());
252
253 // Freeing the last sync node should drop the free nodes to
254 // kFreeNodesLowWatermark.
255 pool_.FreeTabNode(last_sync_id, &changes);
256 EXPECT_FALSE(pool_.Empty());
257 EXPECT_TRUE(pool_.Full());
258 EXPECT_EQ(TabNodePool::kFreeNodesLowWatermark, pool_.Capacity());
259 }
260
261 } // namespace
262
263 } // namespace browser_sync
OLDNEW
« no previous file with comments | « components/sync_driver/tab_node_pool.cc ('k') | components/sync_sessions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698