Handle URLError timeout from Rietveld

verification/try_job_on_rietveld.py

Index: verification/try_job_on_rietveld.py
diff --git a/verification/try_job_on_rietveld.py b/verification/try_job_on_rietveld.py
index b932f8eeb0885a62fa91ea6c40b9dbb05e689d09..dbfb5c0c6ae792a69309c99a37b3d4614804108c 100644
--- a/verification/try_job_on_rietveld.py
+++ b/verification/try_job_on_rietveld.py
@@ -729,6 +729,14 @@ class TryRunnerRietveld(base.VerifierCheckout):
         return False
       else:
         raise
+    except urllib2.URLError as e:

[Paweł Hajdan Jr., 2014/01/28 01:26:29]

Let's just put it right below urllib2.HTTPError.

+      if 'timed out' in e.reason:
+        # Handle timeouts gracefully.
+        logging.warning('%s while updating tryserver status for '
+                        +'rietveld issue %s', e, pending.issue)

[Paweł Hajdan Jr., 2014/01/28 01:26:29]

nit: Add space after +. Actually the + should not be needed.

+        return False
+      else:
+        raise
     except IOError as e:
       # Temporary AppEngine hiccup. Just log it and return failure.
       if e.errno == 'socket error':
@@ -737,6 +745,7 @@ class TryRunnerRietveld(base.VerifierCheckout):
             str(e), str(pending.issue)))
         return False
       raise
+
     if handle:
       for updated_key in keys:
         job = jobs.try_jobs[updated_key]