Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1443083002: [ios] Signal load cancelled after presenting SSL interstitial. (Closed)

Created:
5 years, 1 month ago by stuartmorgan
Modified:
5 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

[ios] Signal load cancelled after presenting SSL interstitial. Without this change web/ never finishes the load after presenting an SSL interstitial. Calling |loadCancelled| fixes the problem and it's the same approach as done in UIWebView. BUG=551585 Review URL: https://codereview.chromium.org/1434453009 Cr-Commit-Position: refs/heads/master@{#358111} (cherry picked from commit 4cdef8fbd9a65b15ba20d62186ce9cea8a677138) Committed: https://chromium.googlesource.com/chromium/src/+/c93a342c88a832e886c3e742c76d07efd7e7b858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
stuartmorgan
5 years, 1 month ago (2015-11-13 17:34:58 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c93a342c88a832e886c3e742c76d07efd7e7b858.

Powered by Google App Engine
This is Rietveld 408576698