Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1434453009: [ios] Signal load cancelled after presenting SSL interstitial. (Closed)

Created:
5 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
5 years, 1 month ago
Reviewers:
stuartmorgan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Signal load cancelled after presenting SSL interstitial. Without this change web/ never finishes the load after presenting an SSL interstitial. Calling |loadCancelled| fixes the problem and it's the same approach as done in UIWebView. BUG=551585 Committed: https://crrev.com/4cdef8fbd9a65b15ba20d62186ce9cea8a677138 Cr-Commit-Position: refs/heads/master@{#358111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Eugene But (OOO till 7-30)
5 years, 1 month ago (2015-11-05 18:55:46 UTC) #2
stuartmorgan
lgtm
5 years, 1 month ago (2015-11-05 19:32:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434453009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434453009/1
5 years, 1 month ago (2015-11-05 19:39:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 19:52:48 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 19:53:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cdef8fbd9a65b15ba20d62186ce9cea8a677138
Cr-Commit-Position: refs/heads/master@{#358111}

Powered by Google App Engine
This is Rietveld 408576698