Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1443033002: Remove dependency on src/android from dm and nanobench (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove dependency on src/android from dm and nanobench BUG=skia: Committed: https://skia.googlesource.com/skia/+/4b0778ec491513d1dab752fddb7520aac19ad47b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M bench/BitmapRegionDecoderBench.cpp View 2 chunks +1 line, -2 lines 2 comments Download
M dm/DM.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M dm/DMSrcSink.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/dm.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/visualbench.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/android/SkBitmapRegionDecoderPriv.h View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1188223002 Patch 60001

Messages

Total messages: 7 (2 generated)
msarett
5 years, 1 month ago (2015-11-13 16:28:48 UTC) #2
mtklein
lgtm https://codereview.chromium.org/1443033002/diff/1/bench/BitmapRegionDecoderBench.cpp File bench/BitmapRegionDecoderBench.cpp (right): https://codereview.chromium.org/1443033002/diff/1/bench/BitmapRegionDecoderBench.cpp#newcode43 bench/BitmapRegionDecoderBench.cpp:43: fName.appendf("_%.3f", 1.0f / (float) sampleSize); all these (float) ...
5 years, 1 month ago (2015-11-13 17:37:10 UTC) #3
msarett
https://codereview.chromium.org/1443033002/diff/1/bench/BitmapRegionDecoderBench.cpp File bench/BitmapRegionDecoderBench.cpp (right): https://codereview.chromium.org/1443033002/diff/1/bench/BitmapRegionDecoderBench.cpp#newcode43 bench/BitmapRegionDecoderBench.cpp:43: fName.appendf("_%.3f", 1.0f / (float) sampleSize); On 2015/11/13 17:37:09, mtklein ...
5 years, 1 month ago (2015-11-13 17:47:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443033002/1
5 years, 1 month ago (2015-11-13 17:47:22 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 17:59:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4b0778ec491513d1dab752fddb7520aac19ad47b

Powered by Google App Engine
This is Rietveld 408576698