chrome/test/data/save_page/frames-nested.htm - Issue 1442733002: Save-Page-As-Complete-Html: Fixing how links are rewritten in subframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/save_page/frames-nested.htm

Issue 1442733002: Save-Page-As-Complete-Html: Fixing how links are rewritten in subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multi-frame-tests

Patch Set: Fixed the name of a test. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/save_page_browsertest.cc ('K') | « chrome/browser/download/save_page_browsertest.cc ('k') | chrome/test/data/save_page/frames-nested2.htm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/save_page/frames-nested.htm

diff --git a/chrome/test/data/save_page/frames-nested.htm b/chrome/test/data/save_page/frames-nested.htm

new file mode 100644

index 0000000000000000000000000000000000000000..ad2f32f87d242c931cd4a60cbf9ca47d22794942

--- /dev/null

+++ b/chrome/test/data/save_page/frames-nested.htm

@@ -0,0 +1,23 @@

+<!doctype html>

+<html>

+<head></head>

+<body>

+ <h1>Test page features</h1>

+ When rewriting links for top-level frame, we need to use links of the

+ form: ./foo_files/some_file.png

+ When rewriting links for other frames (i.e. for frame getting saved

+ into ./foo_files/bar.htm), we need to use links of the form:

+ ./some_other_file.png (i.e. without "foo_files").

+ <h1>Test content</h1>

+ Content verification marker:

+ frames-nested.htm: 4388232f-8d45-4d2e-9807-721b381be153

+ <br>

+ <iframe src="frames-nested2.htm" width="400" height="400"></iframe>

+ <img src="1.png"/>

+</body>

+</html>