chrome/test/data/save_page/frames-nested.htm - Issue 1442733002: Save-Page-As-Complete-Html: Fixing how links are rewritten in subframes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/save_page/frames-nested.htm

Issue 1442733002: Save-Page-As-Complete-Html: Fixing how links are rewritten in subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multi-frame-tests

Patch Set: Fixed the name of a test. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head></head>

	4 <body>

	5 <h1>Test page features</h1>

	6

	7 When rewriting links for top-level frame, we need to use links of the

	8 form: ./foo_files/some_file.png

	9 When rewriting links for other frames (i.e. for frame getting saved

	10 into ./foo_files/bar.htm), we need to use links of the form:

	11 ./some_other_file.png (i.e. without "foo_files").

	12

	13 <h1>Test content</h1>

	14

	15 Content verification marker:

	16 frames-nested.htm: 4388232f-8d45-4d2e-9807-721b381be153

	17 <br>

	18 <br>

	19

	20 <iframe src="frames-nested2.htm" width="400" height="400"></iframe>

	21 <img src="1.png"/>

	22 </body>

	23 </html>

OLD	NEW