Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1442653004: Run the materialized literal reindexer on default parameter initializers (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Run the materialized literal reindexer on default parameter initializers R=rossberg@chromium.org BUG=chromium:554865 LOG=n Committed: https://crrev.com/e971005638f41e7b0f67e91f6e85552e164e13ce Cr-Commit-Position: refs/heads/master@{#31989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-554865.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
adamk
5 years, 1 month ago (2015-11-12 22:11:23 UTC) #1
rossberg
LGTM, thanks for fixing!
5 years, 1 month ago (2015-11-13 07:55:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442653004/1
5 years, 1 month ago (2015-11-13 17:01:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7722)
5 years, 1 month ago (2015-11-13 17:05:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442653004/1
5 years, 1 month ago (2015-11-13 17:08:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 17:10:42 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e971005638f41e7b0f67e91f6e85552e164e13ce
Cr-Commit-Position: refs/heads/master@{#31989}

Powered by Google App Engine
This is Rietveld 408576698