src/parser.cc - Issue 1442653004: Run the materialized literal reindexer on default parameter initializers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 1442653004: Run the materialized literal reindexer on default parameter initializers (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 22efbac101d7586efeac9efcd826f9c2f7b67e1f..2ee9444054e12d8a54d306e6ba112dffe0a958f7 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -4148,6 +4148,7 @@ void ParserTraits::ReindexLiterals(const ParserFormalParameters& parameters) {

for (const auto p : parameters.params) {

if (p.pattern != nullptr) reindexer.Reindex(p.pattern);

+ if (p.initializer != nullptr) reindexer.Reindex(p.initializer);

}

if (parameters.has_rest) {

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-554865.js » ('j') | no next file with comments »