Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1442553003: Lock pixels again after dummy reset of pixel ref in SkBitmapRegionCodec (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Lock pixels again after dummy reset of pixel ref in SkBitmapRegionCodec This fixes a bug in Android. We cannot access the pixels after calling decodeRegion() because the call to lock is missing. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7fdda6091ca0579e823cc014a000828dd53571e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/android/SkBitmapRegionCodec.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
msarett
5 years, 1 month ago (2015-11-12 16:18:02 UTC) #2
scroggo
lgtm
5 years, 1 month ago (2015-11-13 13:40:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442553003/1
5 years, 1 month ago (2015-11-13 13:44:42 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 13:56:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7fdda6091ca0579e823cc014a000828dd53571e6

Powered by Google App Engine
This is Rietveld 408576698