Issue 1442553003: Lock pixels again after dummy reset of pixel ref in SkBitmapRegionCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1442553003: Lock pixels again after dummy reset of pixel ref in SkBitmapRegionCodec (Closed)

Created:
5 years, 1 month ago by msarett

Modified:
5 years, 1 month ago

Reviewers:
scroggo

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Lock pixels again after dummy reset of pixel ref in SkBitmapRegionCodec This fixes a bug in Android. We cannot access the pixels after calling decodeRegion() because the call to lock is missing. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7fdda6091ca0579e823cc014a000828dd53571e6

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/android/SkBitmapRegionCodec.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1188223002 Patch 60001

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442553003/1

5 years, 1 month ago (2015-11-13 13:44:42 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-13 13:56:30 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7fdda6091ca0579e823cc014a000828dd53571e6

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages