Fix mixed sampled inverse path fills

Fix mixed sampled inverse path fills

Fixes a double blend that was occurring down the diagonals of inverse
path fills when using mixed samples.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/3aea7253713c5709a9d8aecff34c1ff508c69a8a

[Chris Dalton, 2015-11-12 02:28:01]

cdalton@nvidia.com changed reviewers:
+ bsalomon@google.com

[Chris Dalton, 2015-11-12 02:28:02]

https://codereview.chromium.org/1442513002/diff/1/src/gpu/batches/GrStencilAn...
File src/gpu/batches/GrStencilAndCoverPathRenderer.cpp (right):

https://codereview.chromium.org/1442513002/diff/1/src/gpu/batches/GrStencilAn...
src/gpu/batches/GrStencilAndCoverPathRenderer.cpp:141:
args.fTarget->drawNonAARect(*pipelineBuilder, args.fColor, viewM, bounds,
invert);
Is "drawNonAARect" more of a perf hint, that says the DT doesn't need to worry
about AA? Or is it intended to be a guarantee that the draw will not be
antialiased?

[bsalomon, 2015-11-12 16:39:32]

lgtm

https://codereview.chromium.org/1442513002/diff/1/src/gpu/batches/GrStencilAn...
File src/gpu/batches/GrStencilAndCoverPathRenderer.cpp (right):

https://codereview.chromium.org/1442513002/diff/1/src/gpu/batches/GrStencilAn...
src/gpu/batches/GrStencilAndCoverPathRenderer.cpp:141:
args.fTarget->drawNonAARect(*pipelineBuilder, args.fColor, viewM, bounds,
invert);
On 2015/11/12 02:28:02, Chris Dalton wrote:
> Is "drawNonAARect" more of a perf hint, that says the DT doesn't need to worry
> about AA? Or is it intended to be a guarantee that the draw will not be
> antialiased?

It's supposed to be strict. It's often used to draw in device space where we
have a rectangle of pixels we want to cover, as in this use case. I'd like to
figure out how to remove or rework this method since it's definition isn't
orthogonal to the pipelinebuilder param it takes. Some of the callers shouldn't
really be calling at the draw target level, but should be using GrDrawContext
(e.g. clip mask manager). We've gone back and forth on whether it should be
possible for a batch to do this type of covering step so that things like this
code path wouldn't need two batches. It's a bit in flux and how that'd be
spec'ed isn't clear yet. It'd be nice if the path renderers could look more like
GrBatch factories where the batch handled the whole path render rather than
whacking on a grdrawtarget.

[Chris Dalton, 2015-11-12 17:05:39]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2015-11-12 17:05:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1442513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1442513002/1

[commit-bot: I haz the power, 2015-11-12 17:18:52]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3aea7253713c5709a9d8aecff34c1ff508c69a8a