Fix mixed sampled inverse path fills

src/gpu/batches/GrStencilAndCoverPathRenderer.cpp

 
 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "GrStencilAndCoverPathRenderer.h"
@@ skipping 117 matching lines @@
             // theoretically could set bloat = 0, instead leave it because of matrix inversion
             // precision.
             SkScalar bloat = viewMatrix.getMaxScale() * SK_ScalarHalf;
             bounds.outset(bloat, bloat);
         } else {
             if (!viewMatrix.invert(&invert)) {
                 return false;
             }
         }
         const SkMatrix& viewM = viewMatrix.hasPerspective() ? SkMatrix::I() : viewMatrix;
+        if (pipelineBuilder->getRenderTarget()->hasMixedSamples()) {
+            pipelineBuilder->disableState(GrPipelineBuilder::kHWAntialias_Flag);
+        }
         args.fTarget->drawNonAARect(*pipelineBuilder, args.fColor, viewM, bounds, invert);

[Chris Dalton, 2015/11/12 02:28:02]

Is "drawNonAARect" more of a perf hint, that says the DT doesn't need to worry
about AA? Or is it intended to be a guarantee that the draw will not be
antialiased?

[bsalomon, 2015/11/12 16:39:32]

It's supposed to be strict. It's often used to draw in device space where we
have a rectangle of pixels we want to cover, as in this use case. I'd like to
figure out how to remove or rework this method since it's definition isn't
orthogonal to the pipelinebuilder param it takes. Some of the callers shouldn't
really be calling at the draw target level, but should be using GrDrawContext
(e.g. clip mask manager). We've gone back and forth on whether it should be
possible for a batch to do this type of covering step so that things like this
code path wouldn't need two batches. It's a bit in flux and how that'd be
spec'ed isn't clear yet. It'd be nice if the path renderers could look more like
GrBatch factories where the batch handled the whole path render rather than
whacking on a grdrawtarget.

     } else {
         GR_STATIC_CONST_SAME_STENCIL(kStencilPass,
             kZero_StencilOp,
             kKeep_StencilOp,
             kNotEqual_StencilFunc,
             0xffff,
             0x0000,
             0xffff);
 
         pipelineBuilder->setStencil(kStencilPass);
         args.fTarget->drawPath(*pipelineBuilder, viewMatrix, args.fColor, p,
                                convert_skpath_filltype(path.getFillType()));
     }
 
     pipelineBuilder->stencil()->setDisabled();
     return true;
 }