chrome/test/data/save_page/frames-objects.htm - Issue 1442463002: Save-Page-As-Complete-HTML: Even better handling of <object> elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/save_page/frames-objects.htm

Issue 1442463002: Save-Page-As-Complete-HTML: Even better handling of <object> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@objects-fix-for-complete-html

Patch Set: Fixing a silly build issue... :-/ Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/save_page/frames-objects.htm

diff --git a/chrome/test/data/save_page/frames-objects.htm b/chrome/test/data/save_page/frames-objects.htm

index 0f521f23f9d2eb2400a08c3a7e40922c803c42ea..974bf8eac833d82f93f0c93015b78eb77b6c9cb2 100644

--- a/chrome/test/data/save_page/frames-objects.htm

+++ b/chrome/test/data/save_page/frames-objects.htm

@@ -9,7 +9,7 @@

Html object:

<br>

- <object data="b.htm" border="1">err_no_object_data</object>

+ <object data="frames-nested.htm" border="1">err_no_object_data</object>

<br>

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | content/renderer/savable_resources.cc » ('j') | no next file with comments »