Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2838)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 1442463002: Save-Page-As-Complete-HTML: Even better handling of <object> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@objects-fix-for-complete-html
Patch Set: Fixing a silly build issue... :-/ Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/save_page/frames-objects.htm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index 993813c4a256b5ffc766a334a68c0f50136bac7e..85147fc722557e130a9049b9df029300620f0b7d 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -1010,12 +1010,14 @@ IN_PROC_BROWSER_TEST_P(SavePageMultiFrameBrowserTest, ObjectElements) {
// 4 = main frame + iframe + object w/ html doc + object w/ pdf doc
// (svg and png objects do not get a separate frame)
- int expected_number_of_frames = 4;
+ int expected_number_of_frames = 6;
std::vector<std::string> expected_substrings{
"frames-objects.htm: 8da13db4-a512-4d9b-b1c5-dc1c134234b9",
"a.htm: 1b8aae2b-e164-462f-bd5b-98aa366205f2",
"b.htm: 3a35f7fa-96a9-4487-9f18-4470263907fa",
+ "frames-nested.htm: 4388232f-8d45-4d2e-9807-721b381be153",
+ "frames-nested2.htm: 6d23dc47-f283-4977-96ec-66bcf72301a4",
};
GURL url(
« no previous file with comments | « no previous file | chrome/test/data/save_page/frames-objects.htm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698